Roll BoringSSL.

Roll BoringSSL.

This pulls in the following changes and fixes boringssl_unittests to account
for CRLF. With this, boringssl_unittests builds and passes on Win32.

c7dd5f3 ERR_GET_* macros return int.
180d1eb Remove SSL_get_shared_ciphers.
176b70e Silence warnings about unused values.
b99106a Fix bio_test on Windows.
66a3531 Fix BIO_printf on Windows.
fb3ff2c Don't compare signed vs. unsigned.
5e77bd4 Use OPENSSL_64_BIT in rc4.c.
04284b8 Account for Windows and UNIX socket API differences.
357fd0a Remove meth_num in ex_data_impl.c.
775b75f Fix Windows shared library build.
de211db Don't use ssize_t in base64_test.c.
ef5c494 Remove OPENSSL_SSL_DEBUG_BROKEN_PROTOCOL.
5b33a5e Merge the get_ssl_method hooks between TLS and SSLv3.
a9ca90a Fix ServerHello EC point format extension check.
42e9a77 Split tls1_check_ec_key.
00075b8 Merge IMPLEMENT_tls_meth_func and IMPLEMENT_ssl3_meth_func.
968ddc9 Not everyone keeps bash in /bin.
5491e3f Clean up ssl_cipher_list_to_bytes a little.
6a3ecf3 _POSIX_C_SOURCE needs to be set to a date, at least on FreeBSD.
eba2384 Missing includes for FreeBSD.
ddb3003 Don't include strings.h because of Windows.
dab64ff Use OPENSSL_strcasecmp.
5d0c163 Also clean the last byte of the PSK identity.
704453f Add deprecated functions for tcpdump.
e7fa75b Remove use of GOTPCREL in asm.

BUG=338884
Committed: https://crrev.com/a511281c308b5589ed44240d45c7e17d8a183a84
Cr-Commit-Position: refs/heads/master@{#297710}

[davidben, 2014-10-01 19:28:23]

davidben@chromium.org changed reviewers:
+ agl@chromium.org

[davidben, 2014-10-01 19:28:25]

Try jobs in flight.

[agl, 2014-10-01 19:35:10]

LGTM with appropriate fix for the Android compile error.

https://codereview.chromium.org/618363002/diff/1/third_party/boringssl/win-x8...
File third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm (right):

https://codereview.chromium.org/618363002/diff/1/third_party/boringssl/win-x8...
third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm:40: mov	r8d,DWORD
PTR[OPENSSL_ia32cap_P]
This is obviously not a no-op change on Windows. It's unclear which is correct.
(It probably doesn't matter for now.)

[davidben, 2014-10-01 19:43:50]

Whoops, fixed. I think that unsigned should probably have been int from the
beginning; ERR_get_next_error_library returns int.

https://codereview.chromium.org/618363002/diff/1/third_party/boringssl/win-x8...
File third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm (right):

https://codereview.chromium.org/618363002/diff/1/third_party/boringssl/win-x8...
third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm:40: mov	r8d,DWORD
PTR[OPENSSL_ia32cap_P]
On 2014/10/01 19:35:10, agl wrote:
> This is obviously not a no-op change on Windows. It's unclear which is
correct.
> (It probably doesn't matter for now.)

Hrm. I'm guessing this is a result the GOTPCREL change. I'm not familiar with
masm syntax... does QWORD PTR vs DWORD PTR change the value of the address? At a
glance it seems equivalent. Load the address of QWORD PTR[OPENSSL_ia32cap_P]
into r8 then read a DWORD from r8 vs. read a DWORD from DWORD
PTR[OPENSSL_ia32cap_P].

I'll build with Win64 later and make sure all the CPUID bits are still doing
something.

[agl, 2014-10-01 20:17:37]

lgtm

https://codereview.chromium.org/618363002/diff/1/third_party/boringssl/win-x8...
File third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm (right):

https://codereview.chromium.org/618363002/diff/1/third_party/boringssl/win-x8...
third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm:40: mov	r8d,DWORD
PTR[OPENSSL_ia32cap_P]
On 2014/10/01 19:43:50, David Benjamin wrote:
> On 2014/10/01 19:35:10, agl wrote:
> > This is obviously not a no-op change on Windows. It's unclear which is
> correct.
> > (It probably doesn't matter for now.)
> 
> Hrm. I'm guessing this is a result the GOTPCREL change. I'm not familiar with
> masm syntax... does QWORD PTR vs DWORD PTR change the value of the address? At
a
> glance it seems equivalent. Load the address of QWORD PTR[OPENSSL_ia32cap_P]
> into r8 then read a DWORD from r8 vs. read a DWORD from DWORD
> PTR[OPENSSL_ia32cap_P].
> 
> I'll build with Win64 later and make sure all the CPUID bits are still doing
> something.

Yes, this is a result of the GOT change.

Actually, I'm much less worried about this now because I didn't notice that the
first instruction is an lea, not a mov.

[davidben, 2014-10-01 20:41:28]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-10-01 20:42:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/618363002/20001

[commit-bot: I haz the power, 2014-10-01 21:23:32]

Committed patchset #2 (id:20001) as 2287372025ac32c060a21f5c684873ea6a4ce124

[commit-bot: I haz the power, 2014-10-01 21:24:28]

Patchset 2 (id:??) landed as
https://crrev.com/a511281c308b5589ed44240d45c7e17d8a183a84
Cr-Commit-Position: refs/heads/master@{#297710}