Issue 618193002: Files.app: Fix typo in onUnload_ handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 618193002: Files.app: Fix typo in onUnload_ handler. (Closed)

Created:
6 years, 2 months ago by hirono

Modified:
6 years, 2 months ago

Reviewers:
fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

Files.app: Fix typo in onUnload_ handler. The type causes an exception and it prevent the app from running progressCenter.removePanel. So the disposed ProgressCenterPanel remains in the ProgressCenter and it causes another bug. BUG=418517 TEST=repo steps of the bug. TBR=fukino@chromium.org Review URL: https://codereview.chromium.org/618563002 Cr-Commit-Position: refs/heads/master@{#297353} (cherry picked from commit 26acebd1856c8de0a2a89da2e73fe7ccec160f30) Committed: https://chromium.googlesource.com/chromium/src/+/0f0240a7b25974c7e7fca188e807e05c34bcf2b1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ui/file_manager/file_manager/foreground/js/file_manager.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

hirono

6 years, 2 months ago (2014-10-01 04:06:08 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f0240a7b25974c7e7fca188e807e05c34bcf2b1 (presubmit successful).