Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 618563002: Files.app: Fix typo in onUnload_ handler. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
iseki, fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix typo in onUnload_ handler. The type causes an exception and it prevent the app from running progressCenter.removePanel. So the disposed ProgressCenterPanel remains in the ProgressCenter and it causes another bug. BUG=418517 TEST=repo steps of the bug. Committed: https://crrev.com/26acebd1856c8de0a2a89da2e73fe7ccec160f30 Cr-Commit-Position: refs/heads/master@{#297353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-09-30 01:52:24 UTC) #2
iseki
LGTM. Thank you for fixing my typo.
6 years, 2 months ago (2014-09-30 02:06:49 UTC) #3
hirono
On 2014/09/30 02:06:49, iseki wrote: > LGTM. > Thank you for fixing my typo. Thanks!
6 years, 2 months ago (2014-09-30 02:14:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618563002/1
6 years, 2 months ago (2014-09-30 02:15:48 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-09-30 02:15:50 UTC) #8
hirono
@yoshiki - PTAL the CL? Thank you!
6 years, 2 months ago (2014-09-30 02:27:50 UTC) #10
hirono
@yoshiki is on vacation. @fukino PTAL? Thank you!
6 years, 2 months ago (2014-09-30 03:08:02 UTC) #12
fukino
On 2014/09/30 03:08:02, hirono wrote: > @yoshiki is on vacation. > @fukino PTAL? Thank you! ...
6 years, 2 months ago (2014-09-30 03:17:59 UTC) #13
hirono
Thank you!
6 years, 2 months ago (2014-09-30 03:18:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618563002/1
6 years, 2 months ago (2014-09-30 03:27:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as afe4248d8bce8e7b1506f9c0dbf63b186579dae7
6 years, 2 months ago (2014-09-30 03:32:34 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 03:33:27 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26acebd1856c8de0a2a89da2e73fe7ccec160f30
Cr-Commit-Position: refs/heads/master@{#297353}

Powered by Google App Engine
This is Rietveld 408576698