Fix crypto_unittests on Windows BoringSSL port.

Fix crypto_unittests on Windows BoringSSL port.

MSVC is somewhat pickier about casting things to bool.

BUG=338884
Committed: https://crrev.com/50a133b51fa9c6a3dc2b82ce9fedcf074859cd13
Cr-Commit-Position: refs/heads/master@{#297770}

[davidben, 2014-10-01 19:44:40]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2014-10-01 19:44:41]

Still working through net_unittests. The CL description not being a lie depends
on https://codereview.chromium.org/618363002/

[Ryan Sleevi, 2014-10-01 20:34:03]

LGTM either way on this nit.

https://codereview.chromium.org/618123007/diff/1/crypto/hmac_openssl.cc
File crypto/hmac_openssl.cc (right):

https://codereview.chromium.org/618123007/diff/1/crypto/hmac_openssl.cc#newco...
crypto/hmac_openssl.cc:57: return ::HMAC(hash_alg_ == SHA1 ? EVP_sha1() :
EVP_sha256(),
Can also go the cheap way that's more idiomatic for Windows programmers

return !!::HMAC(...)

[davidben, 2014-10-02 00:21:36]

https://codereview.chromium.org/618123007/diff/1/crypto/hmac_openssl.cc
File crypto/hmac_openssl.cc (right):

https://codereview.chromium.org/618123007/diff/1/crypto/hmac_openssl.cc#newco...
crypto/hmac_openssl.cc:57: return ::HMAC(hash_alg_ == SHA1 ? EVP_sha1() :
EVP_sha256(),
On 2014/10/01 20:34:03, Ryan Sleevi wrote:
> Can also go the cheap way that's more idiomatic for Windows programmers
> 
> return !!::HMAC(...)

Done.

[davidben, 2014-10-02 00:21:42]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-10-02 00:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/618123007/20001

[commit-bot: I haz the power, 2014-10-02 02:20:50]

Committed patchset #2 (id:20001) as f7cb248137670c2978603175605dcd8da96944e7

[commit-bot: I haz the power, 2014-10-02 02:21:32]

Patchset 2 (id:??) landed as
https://crrev.com/50a133b51fa9c6a3dc2b82ce9fedcf074859cd13
Cr-Commit-Position: refs/heads/master@{#297770}