crypto/hmac_openssl.cc - Issue 618123007: Fix crypto_unittests on Windows BoringSSL port.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/hmac_openssl.cc

Issue 618123007: Fix crypto_unittests on Windows BoringSSL port. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rsleevi comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crypto/hmac_openssl.cc

diff --git a/crypto/hmac_openssl.cc b/crypto/hmac_openssl.cc

index 46bfbaefbeff7acdcf1fcbc2c925ed1a77d93e64..92eea19d780270cde6fa593986ed2015e9687f85 100644

--- a/crypto/hmac_openssl.cc

+++ b/crypto/hmac_openssl.cc

@@ -54,7 +54,7 @@ bool HMAC::Sign(const base::StringPiece& data,

DCHECK(!plat_->key.empty()); // Init must be called before Sign.

ScopedOpenSSLSafeSizeBuffer<EVP_MAX_MD_SIZE> result(digest, digest_length);

- return ::HMAC(hash_alg_ == SHA1 ? EVP_sha1() : EVP_sha256(),

+ return !!::HMAC(hash_alg_ == SHA1 ? EVP_sha1() : EVP_sha256(),

&plat_->key[0], plat_->key.size(),

reinterpret_cast<const unsigned char*>(data.data()),

data.size(),

« no previous file with comments | « crypto/ec_signature_creator_openssl.cc ('k') | crypto/signature_creator_openssl.cc » ('j') | no next file with comments »