content/renderer/render_view_impl.cc - Issue 618013003: Support fullscreen for non-video elements in the WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia

Patch Set: Fix failing test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java ('K') | « content/public/common/web_preferences.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index be5a88bed70820cb9dfd0f0a33370cebf5c21a68..f17f982e43a096992f3ded4877e188a4fc469c6e 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1075,8 +1075,6 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,

settings->setTextAutosizingEnabled(prefs.text_autosizing_enabled);

settings->setAccessibilityFontScaleFactor(prefs.font_scale_factor);

settings->setDeviceScaleAdjustment(prefs.device_scale_adjustment);

- settings->setDisallowFullscreenForNonMediaElements(

- prefs.disallow_fullscreen_for_non_media_elements);

settings->setFullscreenSupported(prefs.fullscreen_supported);

web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom);

settings->setAutoZoomFocusedNodeToLegibleScale(true);