Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia
Patch Set: Fix failing test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 settings->setV8CacheOptions( 1068 settings->setV8CacheOptions(
1069 static_cast<WebSettings::V8CacheOptions>(prefs.v8_cache_options)); 1069 static_cast<WebSettings::V8CacheOptions>(prefs.v8_cache_options));
1070 1070
1071 settings->setV8ScriptStreamingEnabled(prefs.v8_script_streaming_enabled); 1071 settings->setV8ScriptStreamingEnabled(prefs.v8_script_streaming_enabled);
1072 1072
1073 #if defined(OS_ANDROID) 1073 #if defined(OS_ANDROID)
1074 settings->setAllowCustomScrollbarInMainFrame(false); 1074 settings->setAllowCustomScrollbarInMainFrame(false);
1075 settings->setTextAutosizingEnabled(prefs.text_autosizing_enabled); 1075 settings->setTextAutosizingEnabled(prefs.text_autosizing_enabled);
1076 settings->setAccessibilityFontScaleFactor(prefs.font_scale_factor); 1076 settings->setAccessibilityFontScaleFactor(prefs.font_scale_factor);
1077 settings->setDeviceScaleAdjustment(prefs.device_scale_adjustment); 1077 settings->setDeviceScaleAdjustment(prefs.device_scale_adjustment);
1078 settings->setDisallowFullscreenForNonMediaElements(
1079 prefs.disallow_fullscreen_for_non_media_elements);
1080 settings->setFullscreenSupported(prefs.fullscreen_supported); 1078 settings->setFullscreenSupported(prefs.fullscreen_supported);
1081 web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom); 1079 web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom);
1082 settings->setAutoZoomFocusedNodeToLegibleScale(true); 1080 settings->setAutoZoomFocusedNodeToLegibleScale(true);
1083 settings->setDoubleTapToZoomEnabled(prefs.double_tap_to_zoom_enabled); 1081 settings->setDoubleTapToZoomEnabled(prefs.double_tap_to_zoom_enabled);
1084 settings->setMediaControlsOverlayPlayButtonEnabled(true); 1082 settings->setMediaControlsOverlayPlayButtonEnabled(true);
1085 settings->setMediaPlaybackRequiresUserGesture( 1083 settings->setMediaPlaybackRequiresUserGesture(
1086 prefs.user_gesture_required_for_media_playback); 1084 prefs.user_gesture_required_for_media_playback);
1087 settings->setDefaultVideoPosterURL( 1085 settings->setDefaultVideoPosterURL(
1088 base::ASCIIToUTF16(prefs.default_video_poster_url.spec())); 1086 base::ASCIIToUTF16(prefs.default_video_poster_url.spec()));
1089 settings->setSupportDeprecatedTargetDensityDPI( 1087 settings->setSupportDeprecatedTargetDensityDPI(
(...skipping 3102 matching lines...) Expand 10 before | Expand all | Expand 10 after
4192 std::vector<gfx::Size> sizes; 4190 std::vector<gfx::Size> sizes;
4193 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes); 4191 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
4194 if (!url.isEmpty()) 4192 if (!url.isEmpty())
4195 urls.push_back( 4193 urls.push_back(
4196 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes)); 4194 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
4197 } 4195 }
4198 SendUpdateFaviconURL(urls); 4196 SendUpdateFaviconURL(urls);
4199 } 4197 }
4200 4198
4201 } // namespace content 4199 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698