content/browser/android/content_video_view.cc - Issue 618013003: Support fullscreen for non-video elements in the WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_video_view.cc

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia

Patch Set: Fix failing test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java ('K') | « android_webview/native/aw_settings.cc ('k') | content/browser/android/content_view_core_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_video_view.cc

diff --git a/content/browser/android/content_video_view.cc b/content/browser/android/content_video_view.cc

index 901afd4e1f8a6a6ac6d2e703c935a335900456b1..69640562b69e21e71899afa7bd8415ffe9cb1d1b 100644

--- a/content/browser/android/content_video_view.cc

+++ b/content/browser/android/content_video_view.cc

@@ -253,9 +253,8 @@ JavaObjectWeakGlobalRef ContentVideoView::CreateJavaObject() {

env,

Java_ContentVideoView_createContentVideoView(

env,

- content_view_core->GetContext().obj(),

- reinterpret_cast<intptr_t>(this),

- content_view_core->GetContentVideoViewClient().obj()).obj());

+ content_view_core->GetJavaObject().obj(),

+ reinterpret_cast<intptr_t>(this)).obj());

}

void ContentVideoView::CreatePowerSaveBlocker() {