android_webview/native/aw_settings.cc - Issue 618013003: Support fullscreen for non-video elements in the WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_settings.cc

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia

Patch Set: Fix failing test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java ('k') | content/browser/android/content_video_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_settings.cc

diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc

index 012299c678faf27aec9aa80f39e9ba6f3b7997d3..43ea4aebe86f7c1e29254c1ecf4d28dcecbec4ba 100644

--- a/android_webview/native/aw_settings.cc

+++ b/android_webview/native/aw_settings.cc

@@ -401,7 +401,6 @@ void AwSettings::PopulateWebPreferencesLocked(

web_prefs->allow_running_insecure_content =

Java_AwSettings_getAllowRunningInsecureContentLocked(env, obj);

- web_prefs->disallow_fullscreen_for_non_media_elements = true;

web_prefs->fullscreen_supported =

Java_AwSettings_getFullscreenSupportedLocked(env, obj);

}