Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
index a29a3a3ddbff64826fa767220a2da37c890e60e3..7bb8602bb2b4a6dcd28be56822d031758589ea20 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
@@ -418,14 +418,17 @@ public class ContentVideoView extends FrameLayout
@CalledByNative
private static ContentVideoView createContentVideoView(
- Context context, long nativeContentVideoView, ContentVideoViewClient client) {
+ ContentViewCore contentViewCore, long nativeContentVideoView) {
ThreadUtils.assertOnUiThread();
// The context needs be Activity to create the ContentVideoView correctly.
+ Context context = contentViewCore.getContext();
if (!isActivityContext(context)) {
Log.e(TAG, "Wrong type of context, can't create fullscreen video");
return null;
}
- ContentVideoView videoView = new ContentVideoView(context, nativeContentVideoView, client);
+ ContentVideoViewClient client = contentViewCore.getContentVideoViewClient();
+ ContentVideoView videoView = new ContentVideoView(context, nativeContentVideoView,
+ contentViewCore.getContentVideoViewClient());
no sievers 2014/10/15 18:16:38 nit: contentViewCore.getContentVideoViewClient() -
Ignacio Solla 2014/10/15 18:38:42 Done.
client.enterFullscreenVideo(videoView);
return videoView;
}

Powered by Google App Engine
This is Rietveld 408576698