Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 65a6737db55bdb60af51d40d78d4765290907119..9fb16bbf4ca21f153e77b7e4cca008c5d6655cdc 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -392,7 +392,6 @@ public class ContentViewCore
/**
* @return The context used for creating this ContentViewCore.
*/
- @CalledByNative
public Context getContext() {
return mContext;
}
@@ -2702,6 +2701,16 @@ public class ContentViewCore
}
/**
+ * Inform WebKit that Fullscreen mode has been exited by the user
+ * or the app (in the case of the WebView).
+ */
+ public void exitFullscreen() {
+ assert mWebContents != null;
+ mWebContents.exitFullscreen();
no sievers 2014/10/15 18:16:38 Is this needed? Doesn't AwContents have access to
Ignacio Solla 2014/10/15 18:38:42 This function was already here when I started with
+ }
+
+ /**
+ *
* @return The cached copy of render positions and scales.
*/
public RenderCoordinates getRenderCoordinates() {
@@ -2794,8 +2803,7 @@ public class ContentViewCore
private native long nativeInit(long webContentsPtr,
long viewAndroidPtr, long windowAndroidPtr, HashSet<Object> retainedObjectSet);
- @CalledByNative
- private ContentVideoViewClient getContentVideoViewClient() {
+ ContentVideoViewClient getContentVideoViewClient() {
return getContentViewClient().getContentVideoViewClient();
}

Powered by Google App Engine
This is Rietveld 408576698