ppapi_proxy: Support loading and reading urls. Proxy URLLoader....

ppapi_proxy: Support loading and reading urls. Proxy URLLoader.
Enable ppapi_geturl test.

Extend callback support to store buffer pointers for byte reads.

Remove NACL_UNTESTED from the proxy code that ppapi_geturl exercises.
This includes most PPB_URLRequestInfo, PPB_URLResponseInfo,
PPB_URLLoader methods as well as PPB_Instance::GetWindowObject.

Add some dummy code to ppapi_geturl to test PPB_Foo::IsFoo methods.

Rename *url_loader* files to follow the new naming convention.

Comment out a delete statement PluginVar::Release that caused crashes on
subsequent usages of GetWindowObject. Add a comment with a bug link.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=928
TEST= ppapi_geturl, manually in chrome


Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4127

[sehr (please use chromium), 2011-01-12 17:49:12]

One question, two ultra-nits.  Fix and LGTM.

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/brow...
File src/shared/ppapi_proxy/browser_callback.cc (right):

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/brow...
src/shared/ppapi_proxy/browser_callback.cc:52: nacl::scoped_ptr_malloc<char>
read_buffer(remote_callback->read_buffer);
Just curious: is there a reason why you didn't use
new char[size] and scoped_ptr?

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/plug...
File src/shared/ppapi_proxy/plugin_callback.cc (right):

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/plug...
src/shared/ppapi_proxy/plugin_callback.cc:22: return next_id_++;
nit: ++next_id_;

http://codereview.chromium.org/6177007/diff/29001/tests/ppapi_geturl/url_load...
File tests/ppapi_geturl/url_load_request.cc (right):

http://codereview.chromium.org/6177007/diff/29001/tests/ppapi_geturl/url_load...
tests/ppapi_geturl/url_load_request.cc:21: // A local helper that does not
contribut to loading/reading of urls, but
contribute

[polina, 2011-01-12 23:44:26]

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/brow...
File src/shared/ppapi_proxy/browser_callback.cc (right):

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/brow...
src/shared/ppapi_proxy/browser_callback.cc:52: nacl::scoped_ptr_malloc<char>
read_buffer(remote_callback->read_buffer);
On 2011/01/12 17:49:12, sehr wrote:
> Just curious: is there a reason why you didn't use
> new char[size] and scoped_ptr?

No particular reason. Changed.

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/plug...
File src/shared/ppapi_proxy/plugin_callback.cc (right):

http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/plug...
src/shared/ppapi_proxy/plugin_callback.cc:22: return next_id_++;
On 2011/01/12 17:49:12, sehr wrote:
> nit: ++next_id_;

This will return the next id, not the current one, which is wrong. But since all
this ++ business is so confusing, I spelled this out for readability.

http://codereview.chromium.org/6177007/diff/29001/tests/ppapi_geturl/url_load...
File tests/ppapi_geturl/url_load_request.cc (right):

http://codereview.chromium.org/6177007/diff/29001/tests/ppapi_geturl/url_load...
tests/ppapi_geturl/url_load_request.cc:21: // A local helper that does not
contribut to loading/reading of urls, but
On 2011/01/12 17:49:12, sehr wrote:
> contribute

Done.

[sehr (please use chromium), 2011-01-13 00:46:07]

On 2011/01/12 23:44:26, polina wrote:
>
http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/brow...
> File src/shared/ppapi_proxy/browser_callback.cc (right):
> 
>
http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/brow...
> src/shared/ppapi_proxy/browser_callback.cc:52: nacl::scoped_ptr_malloc<char>
> read_buffer(remote_callback->read_buffer);
> On 2011/01/12 17:49:12, sehr wrote:
> > Just curious: is there a reason why you didn't use
> > new char[size] and scoped_ptr?
> 
> No particular reason. Changed.
> 
>
http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/plug...
> File src/shared/ppapi_proxy/plugin_callback.cc (right):
> 
>
http://codereview.chromium.org/6177007/diff/29001/src/shared/ppapi_proxy/plug...
> src/shared/ppapi_proxy/plugin_callback.cc:22: return next_id_++;
> On 2011/01/12 17:49:12, sehr wrote:
> > nit: ++next_id_;
> 
> This will return the next id, not the current one, which is wrong. But since
all
> this ++ business is so confusing, I spelled this out for readability.
> 
>
http://codereview.chromium.org/6177007/diff/29001/tests/ppapi_geturl/url_load...
> File tests/ppapi_geturl/url_load_request.cc (right):
> 
>
http://codereview.chromium.org/6177007/diff/29001/tests/ppapi_geturl/url_load...
> tests/ppapi_geturl/url_load_request.cc:21: // A local helper that does not
> contribut to loading/reading of urls, but
> On 2011/01/12 17:49:12, sehr wrote:
> > contribute
> 
> Done.

LGTM.

[polina, 2011-01-13 01:06:37]

Committed revision 4127.