Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: src/shared/ppapi_proxy/plugin_var.cc

Issue 6177007: ppapi_proxy: Support loading and reading urls. Proxy URLLoader.... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/shared/ppapi_proxy/plugin_url_loader.cc ('k') | src/shared/ppapi_proxy/ppapi_proxy.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/shared/ppapi_proxy/plugin_var.cc
===================================================================
--- src/shared/ppapi_proxy/plugin_var.cc (revision 4123)
+++ src/shared/ppapi_proxy/plugin_var.cc (working copy)
@@ -106,7 +106,11 @@
} else {
obj_impl->object_class()->Deallocate(obj_impl->object_data());
}
- delete obj_impl;
+ // TODO(polina): under test/ppapi_geturl this deletes a window object
+ // prematurely. Most likely we are missing an AddRef somewhere. For now
+ // just comment out the delete and leak.
+ // http://code.google.com/p/nativeclient/issues/detail?id=1308
+ //delete obj_impl;
}
}
StrImpl* str_impl = VarToStrImpl(var);
« no previous file with comments | « src/shared/ppapi_proxy/plugin_url_loader.cc ('k') | src/shared/ppapi_proxy/ppapi_proxy.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698