Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 617693003: gpu: Add CHROMIUM_gpu_memory_buffer_image extension. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@map-image-rename
Project:
chromium
Visibility:
Public.

Description

gpu: Add CHROMIUM_gpu_memory_buffer_image extension. Add initial implementation of CHROMIUM_gpu_memory_buffer_image. This extension will replace current usage of CHROMIUM_image and CHROMIUM_image will later become the more generic extension that can be used by clients that need more control over GpuMemoryBuffer instances. BUG=418553 Committed: https://crrev.com/32115e57190cc45b4914e70797189243f53fffe9 Cr-Commit-Position: refs/heads/master@{#297873}

Patch Set 1 #

Total comments: 1

Patch Set 2 : include WebGraphicsContext3DImpl changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2476 lines, -1075 lines) Patch
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt View 1 chunk +66 lines, -0 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 2 chunks +34 lines, -11 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +25 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 20 chunks +192 lines, -90 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 3 chunks +94 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +1583 lines, -783 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 6 chunks +226 lines, -82 lines 0 comments Download
M ppapi/lib/gl/gles2/gles2.c View 19 chunks +32 lines, -26 lines 0 comments Download
M ppapi/shared_impl/ppb_opengles2_shared.cc View 2 chunks +158 lines, -77 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_impl.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_impl.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reveman
6 years, 2 months ago (2014-09-30 03:47:26 UTC) #2
reveman
https://codereview.chromium.org/617693003/diff/1/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): https://codereview.chromium.org/617693003/diff/1/gpu/command_buffer/client/gles2_implementation.cc#newcode4231 gpu/command_buffer/client/gles2_implementation.cc:4231: internalformat == GL_RGBA ? GL_RGBA8_OES : GL_RGB8_OES, Note that ...
6 years, 2 months ago (2014-09-30 12:38:58 UTC) #3
piman
lgtm
6 years, 2 months ago (2014-10-02 17:47:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617693003/20001
6 years, 2 months ago (2014-10-02 17:48:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6a9110c1e5c989ef4807cf69db4549bd8b9ea102
6 years, 2 months ago (2014-10-02 19:01:24 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 19:02:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32115e57190cc45b4914e70797189243f53fffe9
Cr-Commit-Position: refs/heads/master@{#297873}

Powered by Google App Engine
This is Rietveld 408576698