chrome/chrome_browser.gypi - Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gyp, Add OWNERS, chromium_code=1 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 5bb3872f964f5e746ecaa2081292dae04c85c788..6de4034907088793e57bb76b90df1cc8dd267edd 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -3006,11 +3006,6 @@

'browser/metrics/signin_status_metrics_provider.h',

}],

- ['toolkit_views==1', {

- 'dependencies': [

- '../components/components.gyp:native_app_window',

- ],

- }],

['enable_extensions==1', {

'dependencies': [

'browser_extensions',

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/chrome_browser_ui.gypi » ('j') | chrome/chrome_browser_ui.gypi » ('J')