Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 61763004: Add EmbeddedWorker interfaces in Blink API (Closed)

Created:
7 years, 1 month ago by kinuko
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Total comments: 8

Patch Set 3 : updated #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -56 lines) Patch
A + public/web/WebEmbeddedWorker.h View 1 2 1 chunk +22 lines, -12 lines 0 comments Download
A + public/web/WebEmbeddedWorkerStartData.h View 1 2 1 chunk +15 lines, -9 lines 3 comments Download
A + public/web/WebServiceWorkerContextClient.h View 1 2 1 chunk +24 lines, -26 lines 0 comments Download
A + public/web/WebServiceWorkerContextProxy.h View 1 2 1 chunk +12 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kinuko
I think this one's probably easier than chromium's one. Can you review?
7 years, 1 month ago (2013-11-07 04:02:45 UTC) #1
abarth-chromium
https://codereview.chromium.org/61763004/diff/1/public/web/WebEmbeddedWorker.h File public/web/WebEmbeddedWorker.h (right): https://codereview.chromium.org/61763004/diff/1/public/web/WebEmbeddedWorker.h#newcode38 public/web/WebEmbeddedWorker.h:38: namespace WebKit { WebKit -> blink https://codereview.chromium.org/61763004/diff/1/public/web/WebEmbeddedWorker.h#newcode46 public/web/WebEmbeddedWorker.h:46: class ...
7 years, 1 month ago (2013-11-07 17:51:12 UTC) #2
kinuko
Thanks for reviewing, https://codereview.chromium.org/61763004/diff/1/public/web/WebEmbeddedWorker.h File public/web/WebEmbeddedWorker.h (right): https://codereview.chromium.org/61763004/diff/1/public/web/WebEmbeddedWorker.h#newcode38 public/web/WebEmbeddedWorker.h:38: namespace WebKit { On 2013/11/07 17:51:13, ...
7 years, 1 month ago (2013-11-08 12:17:23 UTC) #3
abarth-chromium
It doesn't look like you've uploaded a new version of your patch, but assuming you've ...
7 years, 1 month ago (2013-11-08 18:03:50 UTC) #4
alecflett
https://codereview.chromium.org/61763004/diff/1/public/web/WebEmbeddedWorkerClient.h File public/web/WebEmbeddedWorkerClient.h (right): https://codereview.chromium.org/61763004/diff/1/public/web/WebEmbeddedWorkerClient.h#newcode45 public/web/WebEmbeddedWorkerClient.h:45: class WebEmbeddedWorkerClient : public WebWorkerPermissionClientProxy { This may be ...
7 years, 1 month ago (2013-11-08 23:18:35 UTC) #5
michaeln
https://codereview.chromium.org/61763004/diff/100001/public/web/WebEmbeddedWorkerStartData.h File public/web/WebEmbeddedWorkerStartData.h (right): https://codereview.chromium.org/61763004/diff/100001/public/web/WebEmbeddedWorkerStartData.h#newcode42 public/web/WebEmbeddedWorkerStartData.h:42: WebEmbeddedWorkerStartModePauseOnStart What is the pause mode about? Is this ...
7 years, 1 month ago (2013-11-12 22:49:59 UTC) #6
kinuko
Thanks, updated. https://codereview.chromium.org/61763004/diff/100001/public/web/WebEmbeddedWorkerStartData.h File public/web/WebEmbeddedWorkerStartData.h (right): https://codereview.chromium.org/61763004/diff/100001/public/web/WebEmbeddedWorkerStartData.h#newcode42 public/web/WebEmbeddedWorkerStartData.h:42: WebEmbeddedWorkerStartModePauseOnStart On 2013/11/12 22:50:00, michaeln wrote: > ...
7 years, 1 month ago (2013-11-18 10:41:13 UTC) #7
michaeln
lgtm I'm assuming the voodoo'ish startdata params are hoisted from the world of sharedworkers? https://codereview.chromium.org/61763004/diff/170001/public/web/WebEmbeddedWorkerStartData.h ...
7 years, 1 month ago (2013-11-18 19:48:15 UTC) #8
kinuko
https://codereview.chromium.org/61763004/diff/170001/public/web/WebEmbeddedWorkerStartData.h File public/web/WebEmbeddedWorkerStartData.h (right): https://codereview.chromium.org/61763004/diff/170001/public/web/WebEmbeddedWorkerStartData.h#newcode48 public/web/WebEmbeddedWorkerStartData.h:48: WebString contentSecurityPolicy; On 2013/11/18 19:48:16, michaeln wrote: > What ...
7 years, 1 month ago (2013-11-19 07:32:29 UTC) #9
kinuko
(I'm going to land this now, hopefully we can iterate on this)
7 years, 1 month ago (2013-11-19 07:33:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/61763004/170001
7 years, 1 month ago (2013-11-19 07:35:03 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 08:33:59 UTC) #12
Message was sent while issue was closed.
Change committed as 162282

Powered by Google App Engine
This is Rietveld 408576698