Add EmbeddedWorker interfaces in Blink API

public/web/WebEmbeddedWorkerClient.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WebInbandTextTrack_h
-#define WebInbandTextTrack_h
+#ifndef WebEmbeddedWorkerClient_h
+#define WebEmbeddedWorkerClient_h
+
+#include "WebWorkerPermissionClientProxy.h"
 
 namespace WebKit {

[abarth-chromium, 2013/11/07 17:51:13]

WebKit -> blink

[kinuko, 2013/11/08 12:17:23]

Done.

 
 class WebString;
-class WebInbandTextTrackClient;
+class WebServiceWorkerGlobalScopeProxy;
 
-class WebInbandTextTrack {
+// This interface is implemented by the client. It is suppoed to be created
+// on the main thread and then passed on to the worker thread to be owned
+// by a newly created WorkerGlobalScope. All methods of this class are
+// called on the worker thread.
+class WebEmbeddedWorkerClient : public WebWorkerPermissionClientProxy {

[alecflett, 2013/11/08 23:18:35]

This may be a non-issue, but it seems odd for an "interface" like this to be
subclassed from this proxy class, rather than letting the implementation choose
to also implement it (i.e. via multiple inheritance)

If I'm totally off base and there are existing patterns like this let me know
too - I'm a little behind on some of the shared worker / permissions cleanup
that you've been doing.

 public:
-    enum Kind {
-        KindSubtitles,
-        KindCaptions,
-        KindDescriptions,
-        KindChapters,
-        KindMetadata,
-        KindNone
-    };
+    // A new WorkerGlobalScope is created and started to run on the
+    // worker thread.
+    // This also gives back a proxy to the client to talk to the
+    // newly created WorkerGlobalScope. The proxy is held by WorkerGlobalScope
+    // and should not be held by the caller. No proxy methods should be called
+    // after workerGlobalScopeDestroyed() is called.
+    virtual void workerGlobalScopeStarted(WebServiceWorkerGlobalScopeProxy*) { }
 
-    enum Mode {
-        ModeDisabled,
-        ModeHidden,
-        ModeShowing
-    };
+    // WorkerGlobalScope.close() is called.
+    virtual void workerGlobalScopeClosed() { }
 
-    virtual ~WebInbandTextTrack() {}
+    // WorkerGlobalScope is destroyed. The client should clear the
+    // WebServiceWorkerGlobalScopeProxy when this is called.
+    virtual void workerGlobalScopeDestroyed() { }
 
-    virtual void setClient(WebInbandTextTrackClient*) = 0;
-    virtual WebInbandTextTrackClient* client() = 0;
-
-    virtual void setMode(Mode) = 0;
-    virtual Mode mode() const = 0;
-
-    virtual Kind kind() const = 0;
-
-    virtual WebString label() const = 0;
-    virtual WebString language() const = 0;
-
-    virtual int textTrackIndex() const = 0;
+    virtual void dispatchDevToolsMessage(const WebString&) { }
+    virtual void saveDevToolsAgentState(const WebString&) { }
 };
 
 } // namespace WebKit
 
-#endif
+#endif // WebEmbeddedWorkerClient_h