Source/core/css/StylePropertySerializer.h - Issue 617493002: Only default to transition shorthand if all 4 values are set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StylePropertySerializer.h

Issue 617493002: Only default to transition shorthand if all 4 values are set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Also add check for animation Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/StylePropertySerializer.h

diff --git a/Source/core/css/StylePropertySerializer.h b/Source/core/css/StylePropertySerializer.h

index 70c16dc565fab7dd7cc864d55ed8e4443a0cab78..72647d44221721784a99ef88c6a522cfdf69dab9 100644

--- a/Source/core/css/StylePropertySerializer.h

+++ b/Source/core/css/StylePropertySerializer.h

@@ -40,7 +40,7 @@ private:

String getCommonValue(const StylePropertyShorthand&) const;

enum CommonValueMode { OmitUncommonValues, ReturnNullOnUncommonValues };

String borderPropertyValue(CommonValueMode) const;

- String getLayeredShorthandValue(const StylePropertyShorthand&) const;

+ String getLayeredShorthandValue(const StylePropertyShorthand&, bool checkShorthandAvailable = false) const;

String get4Values(const StylePropertyShorthand&) const;

String borderSpacingValue(const StylePropertyShorthand&) const;

String getShorthandValue(const StylePropertyShorthand&) const;

« no previous file with comments | « LayoutTests/fast/css/transition-shorthand-cssText-expected.txt ('k') | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »