Source/core/css/StylePropertySerializer.h - Issue 617493002: Only default to transition shorthand if all 4 values are set

Side by Side Diff: Source/core/css/StylePropertySerializer.h

Issue 617493002: Only default to transition shorthand if all 4 values are set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Also add check for animation Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/transition-shorthand-cssText-expected.txt ('k') | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)	2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)

3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.	3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.

4 * Copyright (C) 2011 Research In Motion Limited. All rights reserved.	4 * Copyright (C) 2011 Research In Motion Limited. All rights reserved.

5 * Copyright (C) 2013 Intel Corporation. All rights reserved.	5 * Copyright (C) 2013 Intel Corporation. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 22 matching lines...) Expand all Loading...
33	33

34 class StylePropertySerializer {	34 class StylePropertySerializer {

35 public:	35 public:

36 StylePropertySerializer(const StylePropertySet&);	36 StylePropertySerializer(const StylePropertySet&);

37 String asText() const;	37 String asText() const;

38 String getPropertyValue(CSSPropertyID) const;	38 String getPropertyValue(CSSPropertyID) const;

39 private:	39 private:

40 String getCommonValue(const StylePropertyShorthand&) const;	40 String getCommonValue(const StylePropertyShorthand&) const;

41 enum CommonValueMode { OmitUncommonValues, ReturnNullOnUncommonValues };	41 enum CommonValueMode { OmitUncommonValues, ReturnNullOnUncommonValues };

42 String borderPropertyValue(CommonValueMode) const;	42 String borderPropertyValue(CommonValueMode) const;

43 String getLayeredShorthandValue(const StylePropertyShorthand&) const;	43 String getLayeredShorthandValue(const StylePropertyShorthand&, bool checkSho rthandAvailable = false) const;

44 String get4Values(const StylePropertyShorthand&) const;	44 String get4Values(const StylePropertyShorthand&) const;

45 String borderSpacingValue(const StylePropertyShorthand&) const;	45 String borderSpacingValue(const StylePropertyShorthand&) const;

46 String getShorthandValue(const StylePropertyShorthand&) const;	46 String getShorthandValue(const StylePropertyShorthand&) const;

47 String fontValue() const;	47 String fontValue() const;

48 void appendFontLonghandValueIfExplicit(CSSPropertyID, StringBuilder& result, String& value) const;	48 void appendFontLonghandValueIfExplicit(CSSPropertyID, StringBuilder& result, String& value) const;

49 String backgroundRepeatPropertyValue() const;	49 String backgroundRepeatPropertyValue() const;

50 String getPropertyText(CSSPropertyID, const String& value, bool isImportant, bool isNotFirstDecl) const;	50 String getPropertyText(CSSPropertyID, const String& value, bool isImportant, bool isNotFirstDecl) const;

51 bool isPropertyShorthandAvailable(const StylePropertyShorthand&) const;	51 bool isPropertyShorthandAvailable(const StylePropertyShorthand&) const;

52 bool shorthandHasOnlyInitialOrInheritedValue(const StylePropertyShorthand&) const;	52 bool shorthandHasOnlyInitialOrInheritedValue(const StylePropertyShorthand&) const;

53 void appendBackgroundPropertyAsText(StringBuilder& result, unsigned& numDecl s) const;	53 void appendBackgroundPropertyAsText(StringBuilder& result, unsigned& numDecl s) const;

54	54

55 const StylePropertySet& m_propertySet;	55 const StylePropertySet& m_propertySet;

56 };	56 };

57	57

58 } // namespace blink	58 } // namespace blink

59	59

60 #endif	60 #endif

OLD	NEW