[Telemetry] Support dumpsys power monitoring on the Nexus 5.

[Telemetry] Support dumpsys power monitoring on the Nexus 5.

This adds the necessary commands to programmatically disable charging
on the Nexus 5 as well as fixing a bug in the dumpsys power monitor.

BUG=314481
Committed: https://crrev.com/6d11d3ee12a5ef05d5570661737a900105186fc6
Cr-Commit-Position: refs/heads/master@{#297428}

[tonyg, 2014-09-29 20:46:51]

tonyg@chromium.org changed reviewers:
+ dtu@chromium.org, qsr@chromium.org

[qsr, 2014-09-30 07:36:26]

LGTM with question and nit.

https://chromiumcodereview.appspot.com/617453004/diff/1/tools/telemetry/telem...
File
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
(right):

https://chromiumcodereview.appspot.com/617453004/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:49:
result.split('\n')))
Hum... The test doesn't have the split. Why is it now needed?

https://chromiumcodereview.appspot.com/617453004/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:108:
'Please upgrade the OS version of the device.'
Either add a + at the end of the line, or remove the + on the previous line.

[tonyg, 2014-09-30 14:36:03]

https://chromiumcodereview.appspot.com/617453004/diff/1/tools/telemetry/telem...
File
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
(right):

https://chromiumcodereview.appspot.com/617453004/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:49:
result.split('\n')))
On 2014/09/30 07:36:26, qsr wrote:
> Hum... The test doesn't have the split. Why is it now needed?

It broke with https://codereview.chromium.org/509043002 which changed line 45 to
return a string instead of a list of lines. The unittest calls
ParseSamplingOutput directly and prior to this change, we didn't have bot
coverage for dumpsys power monitor.

https://chromiumcodereview.appspot.com/617453004/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:108:
'Please upgrade the OS version of the device.'
On 2014/09/30 07:36:26, qsr wrote:
> Either add a + at the end of the line, or remove the + on the previous line.

Done.

[tonyg, 2014-09-30 14:38:13]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-09-30 14:39:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617453004/40001

[commit-bot: I haz the power, 2014-09-30 15:39:24]

Committed patchset #3 (id:40001) as fe4b0582e6d4085ed90ed09dbc0a243cb3e77dd3

[commit-bot: I haz the power, 2014-09-30 15:40:01]

Patchset 3 (id:??) landed as
https://crrev.com/6d11d3ee12a5ef05d5570661737a900105186fc6
Cr-Commit-Position: refs/heads/master@{#297428}

[pasko, 2014-10-14 09:16:21]

pasko@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2014-10-14 09:16:22]

https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
build/android/pylib/android_commands.py:83: # Setting the HIZ bit of the bq24192
causes the charger to actually ignore
Wow! Cool! How do I discover similar things for newer devices? TI datasheets are
complex :(

[tonyg, 2014-10-15 00:35:04]

On 2014/10/14 09:16:22, pasko wrote:
>
https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
> File build/android/pylib/android_commands.py (right):
> 
>
https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
> build/android/pylib/android_commands.py:83: # Setting the HIZ bit of the
bq24192
> causes the charger to actually ignore
> Wow! Cool! How do I discover similar things for newer devices? TI datasheets
are
> complex :(

Unfortunately, it was just reading the datasheet :(

[aschulm, 2014-10-15 00:42:11]

On 2014/10/15 00:35:04, tonyg wrote:
> On 2014/10/14 09:16:22, pasko wrote:
> >
>
https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
> > File build/android/pylib/android_commands.py (right):
> > 
> >
>
https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
> > build/android/pylib/android_commands.py:83: # Setting the HIZ bit of the
> bq24192
> > causes the charger to actually ignore
> > Wow! Cool! How do I discover similar things for newer devices? TI datasheets
> are
> > complex :(
> 
> Unfortunately, it was just reading the datasheet :(

Can you send around the datasheet? I'd like to investigate the features of other
power management circuits. I imagine since you are also looking at a TI device
it should also have a HIZ state for the USB charging circuit.

[tonyg, 2014-10-15 00:48:50]

On 2014/10/15 00:42:11, aschulm wrote:
> On 2014/10/15 00:35:04, tonyg wrote:
> > On 2014/10/14 09:16:22, pasko wrote:
> > >
> >
>
https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
> > > File build/android/pylib/android_commands.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/617453004/diff/40001/build/android/pylib/andr...
> > > build/android/pylib/android_commands.py:83: # Setting the HIZ bit of the
> > bq24192
> > > causes the charger to actually ignore
> > > Wow! Cool! How do I discover similar things for newer devices? TI
datasheets
> > are
> > > complex :(
> > 
> > Unfortunately, it was just reading the datasheet :(
> 
> Can you send around the datasheet? I'd like to investigate the features of
other
> power management circuits. I imagine since you are also looking at a TI device
> it should also have a HIZ state for the USB charging circuit.

http://www.ti.com/lit/ds/symlink/bq24192.pdf

[aschulm, 2014-10-15 01:15:13]

> > Can you send around the datasheet? I'd like to investigate the features of
> other
> > power management circuits. I imagine since you are also looking at a TI
device
> > it should also have a HIZ state for the USB charging circuit.
> 
> http://www.ti.com/lit/ds/symlink/bq24192.pdf

Oh I assumed Egor was speaking of a PM circuit that is newer (or at least
different) than the one this patch is for.