Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 509043002: [Telemetry] Combine SysfsPlatformBackend into LinuxBasedPlatformBackend. (Closed)

Created:
6 years, 3 months ago by tonyg
Modified:
6 years, 3 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Combine SysfsPlatformBackend into LinuxBasedPlatformBackend. Sysfs related functionality should have never been a separate Platform. There should just be one Platform at a time. BUG= Committed: https://crrev.com/fcf8643d31301eea990a4c42d7d8c9fc30cc33ec Cr-Commit-Position: refs/heads/master@{#292269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -476 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 7 chunks +35 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 2 chunks +24 lines, -0 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/android_sysfs_platform.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/android_sysfs_platform_unittest.py View 1 chunk +0 lines, -33 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 2 chunks +34 lines, -5 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/cros_platform_backend_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/cros_sysfs_platform.py View 1 chunk +0 lines, -49 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/cros_sysfs_platform_unittest.py View 1 chunk +0 lines, -38 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/linux_based_platform_backend.py View 4 chunks +30 lines, -10 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py View 3 chunks +6 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend.py View 4 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 3 chunks +5 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py View 5 chunks +7 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py View 7 chunks +11 lines, -10 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend.py View 1 chunk +0 lines, -125 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py View 1 chunk +0 lines, -66 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/sysfs_platform.py View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tonyg
tonyg@chromium.org changed reviewers: + dtu@chromium.org
6 years, 3 months ago (2014-08-27 15:33:56 UTC) #1
tonyg
6 years, 3 months ago (2014-08-27 15:34:00 UTC) #2
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 3 months ago (2014-08-27 22:32:57 UTC) #3
dtu
lgtm
6 years, 3 months ago (2014-08-27 22:32:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/509043002/1
6 years, 3 months ago (2014-08-27 22:34:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 23:16:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as e05500aaea3c40e7ef95bd33f34170467d88dffd
6 years, 3 months ago (2014-08-27 23:44:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcf8643d31301eea990a4c42d7d8c9fc30cc33ec
Cr-Commit-Position: refs/heads/master@{#292269}

Powered by Google App Engine
This is Rietveld 408576698