Issue 617443002: Temp fix for crash when generating 16-bit cache for colorTables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 617443002: Temp fix for crash when generating 16-bit cache for colorTables. (Closed)

Created:
6 years, 2 months ago by djsollen

Modified:
6 years, 2 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Temp fix for crash when generating 16-bit cache for colorTables. BUG=skia:2795 Committed: https://skia.googlesource.com/skia/+/47c548a6706cca821f1d0d6489f401bd00e61ab3

Patch Set 2 : comment #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/core/SkColorTable.cpp	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

reed1

lgtm w/ comment request https://codereview.chromium.org/617443002/diff/1/src/core/SkColorTable.cpp File src/core/SkColorTable.cpp (right): https://codereview.chromium.org/617443002/diff/1/src/core/SkColorTable.cpp#newcode76 src/core/SkColorTable.cpp:76: SkASSERT(this->isOpaque()); // Assert that we're ...

6 years, 2 months ago (2014-09-29 14:16:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617443002/20001

6 years, 2 months ago (2014-09-29 15:49:58 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 15:57:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 47c548a6706cca821f1d0d6489f401bd00e61ab3

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 617443002: Temp fix for crash when generating 16-bit cache for colorTables. (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment #

Messages