components/cronet/android/url_request_adapter.h - Issue 617393005: Make URLRequestContextAdapter initialization asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/url_request_adapter.h

Issue 617393005: Make URLRequestContextAdapter initialization asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java ('k') | components/cronet/android/url_request_adapter.cc » ('j') | components/cronet/android/url_request_adapter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/url_request_adapter.h

diff --git a/components/cronet/android/url_request_adapter.h b/components/cronet/android/url_request_adapter.h

index aad1893e6d1961004ee00828f9dda36d8edefbc9..83ecd4d29376e5523a1fb23184b8ffad34d7b280 100644

--- a/components/cronet/android/url_request_adapter.h

+++ b/components/cronet/android/url_request_adapter.h

@@ -116,6 +116,7 @@ class URLRequestAdapter : public net::URLRequest::Delegate {

virtual void OnReadCompleted(net::URLRequest* request,

int bytes_read) OVERRIDE;

+ bool OnNetworkThread() const;

xunjieli 2014/10/03 20:09:55 I made this public, coz URLRequestAdapter::OnDestr

mmenke 2014/10/03 20:26:58 nit: Add linebreak before method.

mmenke 2014/10/03 20:26:58 This is fine.

xunjieli 2014/10/03 20:39:52 Done.

private:

static void OnDestroyRequest(URLRequestAdapter* self);