Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 617393005: Make URLRequestContextAdapter initialization asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
index 4c3dd44ffca2552a946ab95e2b1425d0d2c81e1f..9f99814cff68ec491fd59c5f5305c1333f34b3ef 100644
--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
@@ -5,7 +5,6 @@
package org.chromium.net;
import android.content.Context;
-import android.os.ConditionVariable;
import android.os.Process;
import android.util.Log;
@@ -27,8 +26,6 @@ public class ChromiumUrlRequestContext {
*/
private long mChromiumUrlRequestContextAdapter;
- private final ConditionVariable mStarted = new ConditionVariable();
-
/**
* Constructor.
*
@@ -37,11 +34,9 @@ public class ChromiumUrlRequestContext {
String config) {
mChromiumUrlRequestContextAdapter = nativeCreateRequestContextAdapter(
context, userAgent, getLoggingLevel(), config);
- if (mChromiumUrlRequestContextAdapter == 0)
+ if (mChromiumUrlRequestContextAdapter == 0) {
throw new NullPointerException("Context Adapter creation failed");
-
- // TODO(mef): Revisit the need of block here.
- mStarted.block(2000);
+ }
}
/**
@@ -90,7 +85,6 @@ public class ChromiumUrlRequestContext {
private void initNetworkThread() {
Thread.currentThread().setName("ChromiumNet");
Process.setThreadPriority(Process.THREAD_PRIORITY_BACKGROUND);
- mStarted.open();
}
@Override
« no previous file with comments | « no previous file | components/cronet/android/url_request_adapter.h » ('j') | components/cronet/android/url_request_adapter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698