components/signin/core/browser/profile_oauth2_token_service.h - Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/profile_oauth2_token_service.h

Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Hui's comments, fix cvox tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc ('K') | « components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc ('k') | components/signin/core/browser/profile_oauth2_token_service.cc » ('j') | components/signin/core/browser/signin_manager_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/profile_oauth2_token_service.h

diff --git a/components/signin/core/browser/profile_oauth2_token_service.h b/components/signin/core/browser/profile_oauth2_token_service.h

index b6f133f946a6bd23c10ef2c8f9484ffde0499d34..fbc1fccc5a4ef8ffa0c49cb4fe462c2ea77c7f37 100644

--- a/components/signin/core/browser/profile_oauth2_token_service.h

+++ b/components/signin/core/browser/profile_oauth2_token_service.h

@@ -93,6 +93,10 @@ class ProfileOAuth2TokenService : public OAuth2TokenService,

const std::string& account_id,

const GoogleServiceAuthError& error) override;

+ // Validate that the account_id argument is valid. This method DCHECKs

+ // when invalid.

+ void ValidateAccountId(const std::string& account_id) const;

private:

// The client with which this instance was initialized, or NULL.

SigninClient* client_;