components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc - Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Hui's comments, fix cvox tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc ('K') | « components/signin/core/browser/mutable_profile_oauth2_token_service.cc ('k') | components/signin/core/browser/profile_oauth2_token_service.h » ('j') | components/signin/core/browser/signin_manager_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

diff --git a/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc b/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

index 26b8447844932519f1df2aef27851bdc7c71529b..b7e9a3aa913020778d74a01e5ff532f50f839780 100644

--- a/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

+++ b/components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc

@@ -368,3 +368,16 @@ TEST_F(MutableProfileOAuth2TokenServiceTest, FetchTransientError) {

EXPECT_EQ(GoogleServiceAuthError::AuthErrorNone(),

oauth2_service_.signin_error_controller()->auth_error());

}

+TEST_F(MutableProfileOAuth2TokenServiceTest, CanonicalizeAccountId) {

+ std::map<std::string, std::string> tokens;

+ tokens["AccountId-user@gmail.com"] = "refresh_token";

+ tokens["AccountId-Foo.Bar@gmail.com"] = "refresh_token";

+ tokens["AccountId-12345"] = "refresh_token";

+ oauth2_service_.LoadAllCredentialsIntoMemory(tokens);

+ EXPECT_TRUE(oauth2_service_.RefreshTokenIsAvailable("user@gmail.com"));

+ EXPECT_TRUE(oauth2_service_.RefreshTokenIsAvailable("foobar@gmail.com"));

+ EXPECT_TRUE(oauth2_service_.RefreshTokenIsAvailable("12345"));