Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: Source/platform/fonts/opentype/OpenTypeVerticalData.h

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical
Patch Set: Additional TestExpectations tweaking for Mac Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/SimpleFontData.cpp ('k') | Source/platform/fonts/opentype/OpenTypeVerticalData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/opentype/OpenTypeVerticalData.h
diff --git a/Source/platform/fonts/opentype/OpenTypeVerticalData.h b/Source/platform/fonts/opentype/OpenTypeVerticalData.h
index 61af9af1e3338c8a3e9bb1171bb242310eef3902..ffd95c21da3d1d2ebdeee27a110605c973b5eb08 100644
--- a/Source/platform/fonts/opentype/OpenTypeVerticalData.h
+++ b/Source/platform/fonts/opentype/OpenTypeVerticalData.h
@@ -25,8 +25,6 @@
#ifndef OpenTypeVerticalData_h
#define OpenTypeVerticalData_h
-#if ENABLE(OPENTYPE_VERTICAL)
-
#include "platform/PlatformExport.h"
#include "platform/fonts/Glyph.h"
#include "wtf/HashMap.h"
@@ -50,17 +48,17 @@ public:
bool isOpenType() const { return !m_advanceWidths.isEmpty(); }
bool hasVerticalMetrics() const { return !m_advanceHeights.isEmpty(); }
float advanceHeight(const SimpleFontData*, Glyph) const;
- void getVerticalTranslationsForGlyphs(const SimpleFontData*, const Glyph*, size_t, float* outXYArray) const;
- void substituteWithVerticalGlyphs(const SimpleFontData*, GlyphPage*, unsigned offset, unsigned length) const;
bool inFontCache() const { return m_inFontCache; }
void setInFontCache(bool inFontCache) { m_inFontCache = inFontCache; }
+ void getVerticalTranslationsForGlyphs(const SimpleFontData*, const Glyph*, size_t, float* outXYArray) const;
+
private:
+
explicit OpenTypeVerticalData(const FontPlatformData&);
void loadMetrics(const FontPlatformData&);
- void loadVerticalGlyphSubstitutions(const FontPlatformData&);
bool hasVORG() const { return !m_vertOriginY.isEmpty(); }
HashMap<Glyph, Glyph> m_verticalGlyphMap;
@@ -75,6 +73,4 @@ private:
} // namespace blink
-#endif // ENABLE(OPENTYPE_VERTICAL)
-
#endif // OpenTypeVerticalData_h
« no previous file with comments | « Source/platform/fonts/SimpleFontData.cpp ('k') | Source/platform/fonts/opentype/OpenTypeVerticalData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698