Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: Source/platform/fonts/SimpleFontData.cpp

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical
Patch Set: Additional TestExpectations tweaking for Mac Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/SimpleFontData.h ('k') | Source/platform/fonts/opentype/OpenTypeVerticalData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/SimpleFontData.cpp
diff --git a/Source/platform/fonts/SimpleFontData.cpp b/Source/platform/fonts/SimpleFontData.cpp
index dca35eba0d1a4d202f30af79356c2d0fc9f74ad4..0e32f87044a957eaf90c213bc636bc671c1724d9 100644
--- a/Source/platform/fonts/SimpleFontData.cpp
+++ b/Source/platform/fonts/SimpleFontData.cpp
@@ -60,20 +60,16 @@ SimpleFontData::SimpleFontData(const FontPlatformData& platformData, PassRefPtr<
, m_treatAsFixedPitch(false)
, m_isTextOrientationFallback(isTextOrientationFallback)
, m_isBrokenIdeographFallback(false)
-#if ENABLE(OPENTYPE_VERTICAL)
, m_verticalData(nullptr)
-#endif
, m_hasVerticalGlyphs(false)
, m_customFontData(customData)
{
platformInit();
platformGlyphInit();
-#if ENABLE(OPENTYPE_VERTICAL)
if (platformData.orientation() == Vertical && !isTextOrientationFallback) {
m_verticalData = platformData.verticalData();
m_hasVerticalGlyphs = m_verticalData.get() && m_verticalData->hasVerticalMetrics();
}
-#endif
}
SimpleFontData::SimpleFontData(PassRefPtr<CustomFontData> customData, float fontSize, bool syntheticBold, bool syntheticItalic)
@@ -81,9 +77,7 @@ SimpleFontData::SimpleFontData(PassRefPtr<CustomFontData> customData, float font
, m_treatAsFixedPitch(false)
, m_isTextOrientationFallback(false)
, m_isBrokenIdeographFallback(false)
-#if ENABLE(OPENTYPE_VERTICAL)
, m_verticalData(nullptr)
-#endif
, m_hasVerticalGlyphs(false)
, m_customFontData(customData)
{
« no previous file with comments | « Source/platform/fonts/SimpleFontData.h ('k') | Source/platform/fonts/opentype/OpenTypeVerticalData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698