LayoutTests/fast/writing-mode/text-orientation-basic.html - Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/writing-mode/text-orientation-basic.html

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical

Patch Set: Additional TestExpectations tweaking for Mac Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/writing-mode/text-orientation-basic.html

diff --git a/LayoutTests/fast/writing-mode/text-orientation-basic.html b/LayoutTests/fast/writing-mode/text-orientation-basic.html

index 23782804248eda27cb23af144da71d6b81a3615e..9853439730132a8585923b22e41cf38b72ecaf37 100644

--- a/LayoutTests/fast/writing-mode/text-orientation-basic.html

+++ b/LayoutTests/fast/writing-mode/text-orientation-basic.html

@@ -1,8 +1,7 @@

-<p>This test shows the following bugs with text-orientation. The far right test mis-renders differently in both the simple and complex text paths.

-The simple text path mis-renders because <tt>CTFontGetVerticalTranslationsForGlyphs</tt> returns incorrect values for horizontal glyphs that have vertical

-counterparts. The complex text code path mis-renders because of API deficiency. There is no way to tell CoreText to use upright horizontal glyphs when

-rendering a vertical line.

+<p>This test exercises the vertical text rendering feature of Blink's shaping code, and checks for errors in font code

+ path selection: Vertical text should always go through the shaper. It exercises glyph orientation difficulties with

+ two different fonts.

</p>

« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/build/features.gypi » ('j') | no next file with comments »