LayoutTests/fast/writing-mode/text-orientation-basic.html - Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/writing-mode/text-orientation-basic.html

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical

Patch Set: Additional TestExpectations tweaking for Mac Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/build/features.gypi » ('j') | no next file with comments »

OLD	NEW
1 <body style="overflow:hidden;">	1 <body style="overflow:hidden;">

2 <p>This test shows the following bugs with text-orientation. The far right test mis-renders differently in both the simple and complex text paths.	2 <p>This test exercises the vertical text rendering feature of Blink's shaping co de, and checks for errors in font code

3 The simple text path mis-renders because <tt>CTFontGetVerticalTranslationsForGly phs</tt> returns incorrect values for horizontal glyphs that have vertical	3 path selection: Vertical text should always go through the shaper. It exerci ses glyph orientation difficulties with

4 counterparts. The complex text code path mis-renders because of API deficiency. There is no way to tell CoreText to use upright horizontal glyphs when	4 two different fonts.

5 rendering a vertical line.

6 </p>	5 </p>

7 <div style="-webkit-writing-mode:vertical-lr; height:600px; font-size:36px">	6 <div style="-webkit-writing-mode:vertical-lr; height:600px; font-size:36px">

8 <div style="display:inline-block; border:1px solid green">	7 <div style="display:inline-block; border:1px solid green">

9 <span style="font-family:'Times New Roman'">Hello world</span><br>	8 <span style="font-family:'Times New Roman'">Hello world</span><br>

10 <span style="font-family:'Times New Roman'; -webkit-text-orientation:upright">He llo world</span><br>	9 <span style="font-family:'Times New Roman'; -webkit-text-orientation:upright">He llo world</span><br>

11 <span style="font-family:'Hiragino Kaku Gothic Pro'">Hello world</span><br>	10 <span style="font-family:'Hiragino Kaku Gothic Pro'">Hello world</span><br>

12 <span style="font-family:'Hiragino Kaku Gothic Pro'; -webkit-text-orientation:up right">Hello world</span><br>	11 <span style="font-family:'Hiragino Kaku Gothic Pro'; -webkit-text-orientation:up right">Hello world</span><br>

13 </div>	12 </div>

14	13

15 <div style="display:inline-block; border:1px solid green; text-rendering:optimiz eLegibility">	14 <div style="display:inline-block; border:1px solid green; text-rendering:optimiz eLegibility">

16 <span style="font-family:'Times New Roman'">Hello world</span><br>	15 <span style="font-family:'Times New Roman'">Hello world</span><br>

17 <span style="font-family:'Times New Roman'; -webkit-text-orientation:upright">He llo world</span><br>	16 <span style="font-family:'Times New Roman'; -webkit-text-orientation:upright">He llo world</span><br>

18 <span style="font-family:'Hiragino Kaku Gothic Pro'">Hello world</span><br>	17 <span style="font-family:'Hiragino Kaku Gothic Pro'">Hello world</span><br>

19 <span style="font-family:'Hiragino Kaku Gothic Pro'; -webkit-text-orientation:up right">Hello world</span><br>	18 <span style="font-family:'Hiragino Kaku Gothic Pro'; -webkit-text-orientation:up right">Hello world</span><br>

20 </div>	19 </div>

21 </div>	20 </div>

OLD	NEW