Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/findit/blame.py

Issue 617073010: [Findit] Add timestamp of CL commit and fix two bugs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/findit/crash_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/findit/blame.py
diff --git a/tools/findit/blame.py b/tools/findit/blame.py
index 6acb20fabe46a55f92ee3c7e6432aa722601e625..5e5494e6cd52d4682ebd4c59a86d64f508d2274a 100644
--- a/tools/findit/blame.py
+++ b/tools/findit/blame.py
@@ -20,8 +20,9 @@ class Blame(object):
file_name: The name of the file.
line_number: The line that caused a crash.
author: The author of this line on the latest revision.
- crash_revision: The revision that caused the crash.
revision: The latest revision of this line before the crash revision.
+ message: The commit message for the revision.
+ time: When the revision was committed.
url: The url of the change for the revision.
range_start: The starting range of the regression for this component.
range_end: The ending range of the regression.
@@ -29,7 +30,7 @@ class Blame(object):
"""
def __init__(self, line_content, component_name, stack_frame_index,
- file_name, line_number, author, revision, message,
+ file_name, line_number, author, revision, message, time,
url, range_start, range_end):
# Set all the variables from the arguments.
self.line_content = line_content
@@ -40,6 +41,7 @@ class Blame(object):
self.author = author
self.revision = revision
self.message = message
+ self.time = time
self.url = url
self.range_start = range_start
self.range_end = range_end
@@ -133,9 +135,9 @@ class BlameList(object):
return
# Create blame object from the parsed info and add it to the list.
- (line_content, revision, author, url, message) = parsed_blame_info
+ (line_content, revision, author, url, message, time) = parsed_blame_info
blame = Blame(line_content, component_name, stack_frame_index, file_name,
- crashed_line_number, author, revision, message, url,
+ crashed_line_number, author, revision, message, time, url,
range_start, range_end)
with self.blame_list_lock:
« no previous file with comments | « no previous file | tools/findit/crash_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698