tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 617043003: Handle replay args within replay module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 617043003: Handle replay args within replay module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@combinewpr-localremote-ports

Patch Set: Rebase. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py » ('j') | tools/telemetry/telemetry/core/webpagereplay.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 33d6b7005169bd57a79085768b8719a2296453d8..c54613617ed4e628d6372f3407a949a04b86aa4e 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -66,12 +66,6 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

'such as about:flags settings, cookies, and '

'extensions.\n')

- def AddReplayServerOptions(self, extra_wpr_args):

- if self.browser_options.netsim:

- extra_wpr_args.append('--net=%s' % self.browser_options.netsim)

- else:

nednguyen 2014/10/06 22:07:50 This says append "-no-dns_forwarding" if netsim op

slamm 2014/10/13 21:45:54 If netsim is True, chrome_browser_backend sets the

- extra_wpr_args.append('--no-dns_forwarding')

@property

@decorators.Cache

def extension_backend(self):