Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 617043003: Handle replay args within replay module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@combinewpr-localremote-ports
Patch Set: Rebase. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index f473f41b7c4b84552034ce3119fbb2629c04c0a9..5a41d33cebac6e1ee0c6a9065349a67a9907425e 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -434,9 +434,3 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
self._adb.device_serial()],
stdout=subprocess.PIPE).communicate()[0])
return ret
-
- def AddReplayServerOptions(self, extra_wpr_args):
- if not self.forwarder_factory.does_forwarder_override_dns:
nednguyen 2014/10/06 22:07:50 What is the equivalent of this logic in your chang
slamm 2014/10/13 21:45:54 In webpagereplay, --no-dns_forwarding is added whe
- extra_wpr_args.append('--no-dns_forwarding')
- if self.browser_options.netsim:
- extra_wpr_args.append('--net=%s' % self.browser_options.netsim)

Powered by Google App Engine
This is Rietveld 408576698