Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 616953005: Revert of Add --output-dir flag for page_runner.py. (Closed)

Created:
6 years, 2 months ago by dtu
Modified:
6 years, 2 months ago
Reviewers:
ariblue, nednguyen, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add --output-dir flag for page_runner.py. (patchset #2 id:40001 of https://codereview.chromium.org/616063004/) Reason for revert: Failing on all perf bots in generate_telemetry_profiles: Traceback (most recent call last): <module> at tools/perf/generate_profile:13 sys.exit(profile_generator.Main()) Main at tools/telemetry/telemetry/page/profile_generator.py:145 AddCommandLineArgs(parser) AddCommandLineArgs at tools/telemetry/telemetry/page/profile_generator.py:115 help='Generated profile is placed in this directory.') add_option at /usr/lib/python2.7/optparse.py:1020 self._check_conflict(option) _check_conflict at /usr/lib/python2.7/optparse.py:995 option) OptionConflictError: option --output-dir: conflicting option string(s): --output-dir Locals: co : ('--output-dir', <Option at 0x2b074d0: --output-dir>) conflict_opts : [('--output-dir', <Option at 0x2b074d0: --output-dir>)] handler : 'error' opt : '--output-dir' option : <Option at 0x2b08290: --output-dir> Original issue's description: > Add --output-dir flag for page_runner.py to specify a custom directory for > output profiling and results data. > > Motivation behind this flag: I've run into a bug where a run on a local device > and a run on the try bots are showing different versions of the page. I wanted > to use the android_screen_recorder_profiler.py to record the try bot version > and see what it is actually showing. However, it currently tries to output the > video to a temporary directory in /tmp (which I do not have permission to write > to). > > BUG= > > Committed: https://crrev.com/2a859c8f48b40d7bc443812e6cf760f10e0d22ba > Cr-Commit-Position: refs/heads/master@{#297740} TBR=tonyg@chromium.org,nednguyen@google.com,ariblue@google.com NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9a8da4ab85ca3836272034b5dd9de1c9717af9bc Cr-Commit-Position: refs/heads/master@{#297778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 2 chunks +1 line, -5 lines 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 4 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dtu
Created Revert of Add --output-dir flag for page_runner.py.
6 years, 2 months ago (2014-10-02 03:34:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616953005/1
6 years, 2 months ago (2014-10-02 03:34:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 19157fd7c5821cd97d4e871545fdc336858c4c45
6 years, 2 months ago (2014-10-02 03:35:04 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 03:35:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a8da4ab85ca3836272034b5dd9de1c9717af9bc
Cr-Commit-Position: refs/heads/master@{#297778}

Powered by Google App Engine
This is Rietveld 408576698