DescriptionRevert of Add --output-dir flag for page_runner.py. (patchset #2 id:40001 of https://codereview.chromium.org/616063004/)
Reason for revert:
Failing on all perf bots in generate_telemetry_profiles:
Traceback (most recent call last):
<module> at tools/perf/generate_profile:13
sys.exit(profile_generator.Main())
Main at tools/telemetry/telemetry/page/profile_generator.py:145
AddCommandLineArgs(parser)
AddCommandLineArgs at tools/telemetry/telemetry/page/profile_generator.py:115
help='Generated profile is placed in this directory.')
add_option at /usr/lib/python2.7/optparse.py:1020
self._check_conflict(option)
_check_conflict at /usr/lib/python2.7/optparse.py:995
option)
OptionConflictError: option --output-dir: conflicting option string(s): --output-dir
Locals:
co : ('--output-dir', <Option at 0x2b074d0: --output-dir>)
conflict_opts : [('--output-dir', <Option at 0x2b074d0: --output-dir>)]
handler : 'error'
opt : '--output-dir'
option : <Option at 0x2b08290: --output-dir>
Original issue's description:
> Add --output-dir flag for page_runner.py to specify a custom directory for
> output profiling and results data.
>
> Motivation behind this flag: I've run into a bug where a run on a local device
> and a run on the try bots are showing different versions of the page. I wanted
> to use the android_screen_recorder_profiler.py to record the try bot version
> and see what it is actually showing. However, it currently tries to output the
> video to a temporary directory in /tmp (which I do not have permission to write
> to).
>
> BUG=
>
> Committed: https://crrev.com/2a859c8f48b40d7bc443812e6cf760f10e0d22ba
> Cr-Commit-Position: refs/heads/master@{#297740}
TBR=tonyg@chromium.org,nednguyen@google.com,ariblue@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/9a8da4ab85ca3836272034b5dd9de1c9717af9bc
Cr-Commit-Position: refs/heads/master@{#297778}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|