tools/telemetry/telemetry/page/page_runner.py - Issue 616953005: Revert of Add --output-dir flag for page_runner.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 616953005: Revert of Add --output-dir flag for page_runner.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 11a532b9d8779ad9afe45e76ade938e9fef87a2c..fa5c347cfffc56a19c375ae1cdf5c0f1c1b3bd95 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -124,10 +124,7 @@

def StartProfiling(self, page, finder_options):

if not self.profiler_dir:

- if finder_options.output_dir:

- self.profiler_dir = finder_options.output_dir

- else:

- self.profiler_dir = tempfile.mkdtemp()

+ self.profiler_dir = tempfile.mkdtemp()

output_file = os.path.join(self.profiler_dir, page.file_safe_name)

is_repeating = (finder_options.page_repeat != 1 or

finder_options.pageset_repeat != 1)

@@ -222,7 +219,6 @@

def ProcessCommandLineArgs(parser, args):

page_filter.PageFilter.ProcessCommandLineArgs(parser, args)

- results_options.ProcessCommandLineArgs(parser, args)

# Page set options

if args.pageset_shuffle_order_file and not args.pageset_shuffle:

« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/results_options.py » ('j') | no next file with comments »