Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 616953002: Fix for NPE when FieldFormalParameterElement references an unresolved field. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for NPE when FieldFormalParameterElement references an unresolved field. I found it (in a hard way - server died) during dogfooding. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 2 months ago (2014-09-30 17:45:00 UTC) #1
Paul Berry
6 years, 2 months ago (2014-09-30 17:50:24 UTC) #2
Paul Berry
lgtm
6 years, 2 months ago (2014-09-30 17:50:30 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 40820 (presubmit successful).
6 years, 2 months ago (2014-09-30 17:59:20 UTC) #4
Brian Wilkerson
6 years, 2 months ago (2014-09-30 18:09:38 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698