Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: pkg/analysis_server/lib/src/computer/computer_navigation.dart

Issue 616953002: Fix for NPE when FieldFormalParameterElement references an unresolved field. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/notification_navigation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/computer/computer_navigation.dart
diff --git a/pkg/analysis_server/lib/src/computer/computer_navigation.dart b/pkg/analysis_server/lib/src/computer/computer_navigation.dart
index bce017c7bceeef3ec02d74b5ec1a1c13d44ee5e5..a82cbe1e20c64fb4e0d509eeda59c372698d79c0 100644
--- a/pkg/analysis_server/lib/src/computer/computer_navigation.dart
+++ b/pkg/analysis_server/lib/src/computer/computer_navigation.dart
@@ -30,12 +30,12 @@ class DartUnitNavigationComputer {
}
void _addRegion(int offset, int length, Element element) {
- if (element == null || element == DynamicElementImpl.instance) {
- return;
- }
if (element is FieldFormalParameterElement) {
element = (element as FieldFormalParameterElement).field;
}
+ if (element == null || element == DynamicElementImpl.instance) {
+ return;
+ }
protocol.Element target = new protocol.Element.fromEngine(element);
_regions.add(new protocol.NavigationRegion(offset, length, [target]));
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/notification_navigation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698