Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 616903003: Shortening thank you message for a cleaner output. (Closed)

Created:
6 years, 2 months ago by RobertoCN
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Shortening thank you message for a cleaner output. Also, restoring ttest constants to original values in ttest_test. I made a minor change to the ascii scissors. Please review. BUG=404088 Committed: https://crrev.com/71671602096ea033ca3dcf503f54f3964f0d1f6d Cr-Commit-Position: refs/heads/master@{#297457}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Repro steps: git try instead of git cl try. #

Patch Set 3 : Cosmetic change, prevent leading space trim. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
RobertoCN
6 years, 2 months ago (2014-09-30 17:15:37 UTC) #2
qyearsley
On 2014/09/30 17:15:37, robertocn wrote: LGTM, thank you! I need to remember in the future ...
6 years, 2 months ago (2014-09-30 17:22:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616903003/1
6 years, 2 months ago (2014-09-30 17:29:27 UTC) #5
prasadv
lgtm https://codereview.chromium.org/616903003/diff/1/tools/auto_bisect/bisect_perf_regression.py File tools/auto_bisect/bisect_perf_regression.py (right): https://codereview.chromium.org/616903003/diff/1/tools/auto_bisect/bisect_perf_regression.py#newcode225 tools/auto_bisect/bisect_perf_regression.py:225: 2. Upload your patch with: $ git cl ...
6 years, 2 months ago (2014-09-30 17:35:02 UTC) #7
prasadv
6 years, 2 months ago (2014-09-30 17:35:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616903003/20001
6 years, 2 months ago (2014-09-30 17:47:08 UTC) #10
RobertoCN
https://codereview.chromium.org/616903003/diff/1/tools/auto_bisect/bisect_perf_regression.py File tools/auto_bisect/bisect_perf_regression.py (right): https://codereview.chromium.org/616903003/diff/1/tools/auto_bisect/bisect_perf_regression.py#newcode225 tools/auto_bisect/bisect_perf_regression.py:225: 2. Upload your patch with: $ git cl upload ...
6 years, 2 months ago (2014-09-30 18:10:11 UTC) #11
prasadv
lgtm
6 years, 2 months ago (2014-09-30 18:12:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 432ce846ab89201086239d470ecc1528f832f094
6 years, 2 months ago (2014-09-30 18:22:34 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:23:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71671602096ea033ca3dcf503f54f3964f0d1f6d
Cr-Commit-Position: refs/heads/master@{#297457}

Powered by Google App Engine
This is Rietveld 408576698