Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 616903003: Shortening thank you message for a cleaner output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/auto_bisect/ttest_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Performance Test Bisect Tool 6 """Performance Test Bisect Tool
7 7
8 This script bisects a series of changelists using binary search. It starts at 8 This script bisects a series of changelists using binary search. It starts at
9 a bad revision where a performance metric has regressed, and asks for a last 9 a bad revision where a performance metric has regressed, and asks for a last
10 known-good revision. It will then binary search across this revision range by 10 known-good revision. It will then binary search across this revision range by
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 REPRO_STEPS_LOCAL = """ 215 REPRO_STEPS_LOCAL = """
216 ==== INSTRUCTIONS TO REPRODUCE ==== 216 ==== INSTRUCTIONS TO REPRODUCE ====
217 To run locally: 217 To run locally:
218 - Use the test command given under 'BISECT JOB RESULTS' above. 218 - Use the test command given under 'BISECT JOB RESULTS' above.
219 - Consider using a profiler. Pass --profiler=list to list available profilers. 219 - Consider using a profiler. Pass --profiler=list to list available profilers.
220 """ 220 """
221 221
222 REPRO_STEPS_TRYJOB = """ 222 REPRO_STEPS_TRYJOB = """
223 To reproduce on a performance try bot: 223 To reproduce on a performance try bot:
224 1. Edit run-perf-test.cfg 224 1. Edit run-perf-test.cfg
225 2. Upload your patch with: $ git cl upload --bypass-hooks 225 2. Upload your patch with: $ git cl upload --bypass-hooks
prasadv 2014/09/30 17:35:02 should we also change this. Now that git try is su
RobertoCN 2014/09/30 18:10:11 Done.
226 3. Send to the try server: $ git cl try -m tryserver.chromium.perf -b <bot> 226 3. Send to the try server: $ git cl try -m tryserver.chromium.perf -b <bot>
227 227
228 Notes: 228 Notes:
229 a) Follow the in-file instructions in run-perf-test.cfg. 229 a) Follow the in-file instructions in run-perf-test.cfg.
230 b) run-perf-test.cfg is under tools/ or under third_party/WebKit/Tools. 230 b) run-perf-test.cfg is under tools/ or under third_party/WebKit/Tools.
231 c) Do your edits preferably under a new git branch. 231 c) Do your edits preferably under a new git branch.
232 d) --browser=release and --browser=android-chromium-testshell are supported 232 d) --browser=release and --browser=android-chromium-testshell are supported
233 depending on the platform (desktop|android). 233 depending on the platform (desktop|android).
234 e) Strip any src/ directories from the head of relative path names. 234 e) Strip any src/ directories from the head of relative path names.
235 f) Make sure to use the appropriate bot on step 3. 235 f) Make sure to use the appropriate bot on step 3.
236 236
237 For more details please visit 237 For more details please visit
238 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots""" 238 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots"""
239 239
240 REPRO_STEPS_TRYJOB_TELEMETRY = """ 240 REPRO_STEPS_TRYJOB_TELEMETRY = """
241 To reproduce on a performance try bot: 241 To reproduce on a performance try bot:
242 %(command)s 242 %(command)s
243 (Where <bot-name> comes from tools/perf/run_benchmark --browser=list) 243 (Where <bot-name> comes from tools/perf/run_benchmark --browser=list)
244 244
245 For more details please visit 245 For more details please visit
246 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots 246 https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots
247 """ 247 """
248 248
249 RESULTS_THANKYOU = """ 249 RESULTS_THANKYOU = """
250 ===== THANK YOU FOR CHOOSING BISECT AIRLINES ===== 250 O O | Visit http://www.chromium.org/developers/core-principles for Chrome's
251 Visit http://www.chromium.org/developers/core-principles for Chrome's policy 251 X | policy on perf regressions. Contact chrome-perf-dashboard-team with any
252 on perf regressions. 252 / \ | questions or suggestions about bisecting. THANK YOU."""
253 Contact chrome-perf-dashboard-team with any questions or suggestions about
254 bisecting.
255 . .-----.
256 . .---. \ \==)
257 . |PERF\ \ \\
258 . | ---------'-------'-----------.
259 . . 0 0 0 0 0 0 0 0 0 0 0 0 0 0 |_`-.
260 . \_____________.-------._______________)
261 . / /
262 . / /
263 . / /==)
264 . ._____."""
265 253
266 254
267 def _AddAdditionalDepotInfo(depot_info): 255 def _AddAdditionalDepotInfo(depot_info):
268 """Adds additional depot info to the global depot variables.""" 256 """Adds additional depot info to the global depot variables."""
269 global DEPOT_DEPS_NAME 257 global DEPOT_DEPS_NAME
270 global DEPOT_NAMES 258 global DEPOT_NAMES
271 DEPOT_DEPS_NAME = dict(DEPOT_DEPS_NAME.items() + depot_info.items()) 259 DEPOT_DEPS_NAME = dict(DEPOT_DEPS_NAME.items() + depot_info.items())
272 DEPOT_NAMES = DEPOT_DEPS_NAME.keys() 260 DEPOT_NAMES = DEPOT_DEPS_NAME.keys()
273 261
274 262
(...skipping 2905 matching lines...) Expand 10 before | Expand all | Expand 10 after
3180 # bugs. If you change this, please update the perf dashboard as well. 3168 # bugs. If you change this, please update the perf dashboard as well.
3181 bisect_utils.OutputAnnotationStepStart('Results') 3169 bisect_utils.OutputAnnotationStepStart('Results')
3182 print 'Error: %s' % e.message 3170 print 'Error: %s' % e.message
3183 if opts.output_buildbot_annotations: 3171 if opts.output_buildbot_annotations:
3184 bisect_utils.OutputAnnotationStepClosed() 3172 bisect_utils.OutputAnnotationStepClosed()
3185 return 1 3173 return 1
3186 3174
3187 3175
3188 if __name__ == '__main__': 3176 if __name__ == '__main__':
3189 sys.exit(main()) 3177 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | tools/auto_bisect/ttest_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698