runtime/vm/disassembler_arm64.cc - Issue 616873003: Use UnboxedInt32 and UnboxedUint32 representation for LoadIndexedInstr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_arm64.cc

Issue 616873003: Use UnboxedInt32 and UnboxedUint32 representation for LoadIndexedInstr (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_arm64.cc

diff --git a/runtime/vm/disassembler_arm64.cc b/runtime/vm/disassembler_arm64.cc

index 6b38b78d2ae9182a7b5e9e292c881265bcdfb87f..66d914f9832ee67c3332136dc2598cd590395d92 100644

--- a/runtime/vm/disassembler_arm64.cc

+++ b/runtime/vm/disassembler_arm64.cc

@@ -1201,11 +1201,18 @@ void ARM64Decoder::DecodeFPImm(Instr* instr) {

void ARM64Decoder::DecodeFPIntCvt(Instr* instr) {

- if ((instr->SFField() != 1) || (instr->Bit(29) != 0) ||

- (instr->Bits(22, 2) != 1)) {

+ if ((instr->Bit(29) != 0) || (instr->Bits(22, 2) != 1)) {

Unknown(instr);

return;

}

+ if (instr->SFField() == 0) {

zra 2014/10/09 18:00:30 Remove this if() {} and just use the format string

Cutch 2014/10/09 18:49:11 Done.

+ if (instr->Bits(16, 5) == 2) {

+ Format(instr, "scvtfd 'vd, 'vn");

+ } else {

+ Unknown(instr);

+ }

+ return;

+ }

if (instr->Bits(16, 5) == 2) {

Format(instr, "scvtfd 'vd, 'vn");

zra 2014/10/09 18:00:30 "scvtfd'sf 'vd, 'rn"

Cutch 2014/10/09 18:49:11 Done.

} else if (instr->Bits(16, 5) == 6) {

« runtime/vm/assembler_arm64.h ('K') | « runtime/vm/constants_arm64.h ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | runtime/vm/simulator_arm64.cc » ('J')