Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 616833002: [turbofan] ia32 lea multiplication matching (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] ia32 lea multiplication matching R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -25 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +41 lines, -21 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32-unittest.cc View 3 chunks +82 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal note: i undid a change to constant fold in the addressing mode matching since ...
6 years, 2 months ago (2014-09-30 10:01:39 UTC) #1
Benedikt Meurer
LGTM
6 years, 2 months ago (2014-09-30 10:43:58 UTC) #2
dcarney
6 years, 2 months ago (2014-09-30 11:22:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24326 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698