Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: tools/perf/page_sets/key_mobile_sites.py

Issue 616693002: Kill page.disabled field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/perf/page_sets/key_silk_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_mobile_sites.py
diff --git a/tools/perf/page_sets/key_mobile_sites.py b/tools/perf/page_sets/key_mobile_sites.py
index e9c82ca2bced891b08968eedceb981d2c10f2a1d..b65226656f348785364d89dab60e1e3e160e4bd6 100644
--- a/tools/perf/page_sets/key_mobile_sites.py
+++ b/tools/perf/page_sets/key_mobile_sites.py
@@ -210,7 +210,6 @@ class Page13(KeyMobileSitesPage):
url='http://twitter.com/katyperry',
page_set=page_set,
name='Twitter')
- self.disabled = 'Forbidden (Rate Limit Exceeded)'
class Page14(KeyMobileSitesPage):
@@ -233,7 +232,6 @@ class Page15(KeyMobileSitesPage):
url='http://espn.go.com',
page_set=page_set,
name='ESPN')
- self.disabled = 'Fails often; crbug.com/249722'
class Page16(KeyMobileSitesPage):
@@ -328,8 +326,6 @@ class Page21(KeyMobileSitesPage):
url='http://groupcloned.com',
page_set=page_set)
- self.disabled = ('Page behaves non-deterministically, replaced with test'
- 'version for now')
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
@@ -390,8 +386,6 @@ class Page23(KeyMobileSitesPage):
url='http://forecast.io',
page_set=page_set)
- self.disabled = u"Doesn't scroll; crbug.com/249736"
-
class Page24(KeyMobileSitesPage):
@@ -481,19 +475,24 @@ class KeyMobileSitesPageSet(page_set_module.PageSet):
self.AddPage(Page10(self))
self.AddPage(Page11(self))
self.AddPage(Page12(self))
-# self.AddPage(Page13(self))
+ # Forbidden (Rate Limit Exceeded)
+ # self.AddPage(Page13(self))
self.AddPage(Page14(self))
-# self.AddPage(Page15(self))
+ # Fails often; crbug.com/249722'
+ # self.AddPage(Page15(self))
self.AddPage(Page16(self))
self.AddPage(Page17(self))
self.AddPage(Page18(self))
self.AddPage(Page19(self))
self.AddPage(Page20(self))
- self.AddPage(Page21(self))
-# mean_input_event_latency cannot be tracked correctly for Page22.
-# See crbug.com/409086.
-# self.AddPage(Page22(self))
-# self.AddPage(Page23(self))
+ # Page behaves non-deterministically, replaced with test version for now.
+ # self.AddPage(Page21(self))
+ # mean_input_event_latency cannot be tracked correctly for Page22.
+ # See crbug.com/409086.
+ # self.AddPage(Page22(self))
+ # self.AddPage(Page23(self))
+ # Doesn't scroll; crbug.com/249736
+ # self.AddPage(Page23(self))
self.AddPage(Page24(self))
self.AddPage(Page25(self))
self.AddPage(Page26(self))
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/perf/page_sets/key_silk_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698