Expose IA and IA2 role and state for HTML input type attributes related to date and time.

Expose IA and IA2 role and state for HTML input type attributes related to date and time.

For input type date, datetime and datetime-local, time, month, week - IA and IA2 role and states
are not exposed properly.

This is chromium side CL for this blink side CL https://codereview.chromium.org/615773002

BUG=418486, 170586, 170575
Committed: https://crrev.com/a89bdd193687e7cb9ad022bc01e97c93cbd018a6
Cr-Commit-Position: refs/heads/master@{#299677}

[shreeramk, 2014-10-01 16:27:50]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org, mkwst@chromium.org, plundblad@chromium.org

[shreeramk, 2014-10-01 16:27:51]

Please review.

Expectations file for mac will have AXUnknown for respective input types.

Presently I don't have a mac system with me. I ll fix bugs related to input
types for mac as soon as I get a mac system.


Thanks!

[Mike West, 2014-10-01 17:56:41]

The code change LGTM, though I defer to Dominic regarding whether or not the
exact values you've chosen are accurate.

Regarding the tests, however, I don't understand your comment: are you going to
extend this CL such that those types don't show up as Unknown? Is there
blink-side work to be done? If the latter, you should mark them as skipped for
the moment.

[shreeramk, 2014-10-01 18:35:52]

On 2014/10/01 17:56:41, Mike West wrote:
> The code change LGTM, though I defer to Dominic regarding whether or not the
> exact values you've chosen are accurate.
> 
> Regarding the tests, however, I don't understand your comment: are you going
to
> extend this CL such that those types don't show up as Unknown? Is there
> blink-side work to be done? If the latter, you should mark them as skipped for
> the moment.

Chromium side changes are required for mac platform to dump the correct
attributes for input types. I ll submit the changes for mac in next CL.

The current uploaded expectations for mac will not cause any failures. So, I
think no need to skip.

[Mike West, 2014-10-01 18:42:01]

On 2014/10/01 18:35:52, shreeram.k wrote:
> Chromium side changes are required for mac platform to dump the correct
> attributes for input types. I ll submit the changes for mac in next CL.

Ok, great. Chromium-side changes are perfectly fine, as you can change code at
the same time you change the test (if Blink-side patches change these results,
however, then you need to skip them. Otherwise when you make the Blink-side
change, the test results won't match the expected results after rolling Blink
into Chromium, and the roll will be blocked).

Still LGTM, but you'll need Dominic to sign off before landing.

[dmazzoni, 2014-10-01 19:42:06]

lgtm with two fixes

https://codereview.chromium.org/616473002/diff/40001/content/shell/renderer/t...
File content/shell/renderer/test_runner/web_ax_object_proxy.cc (right):

https://codereview.chromium.org/616473002/diff/40001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_ax_object_proxy.cc:64: return
result.append("TextField");
This should be DateTime or DateTimeField, right?

https://codereview.chromium.org/616473002/diff/40001/ui/accessibility/ax_enum...
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/616473002/diff/40001/ui/accessibility/ax_enum...
ui/accessibility/ax_enums.idl:83: date,
See this comment:

// For new entries to the following three enums, also add to
// chrome/common/extensions/api/automation.idl.

Can you please double-check automation.idl is completely in sync? Add new
unrelated enums if you see any other differences.

[shreeramk, 2014-10-06 03:55:38]

On 2014/10/01 19:42:06, dmazzoni wrote:
> lgtm with two fixes
> 
>
https://codereview.chromium.org/616473002/diff/40001/content/shell/renderer/t...
> File content/shell/renderer/test_runner/web_ax_object_proxy.cc (right):
> 
>
https://codereview.chromium.org/616473002/diff/40001/content/shell/renderer/t...
> content/shell/renderer/test_runner/web_ax_object_proxy.cc:64: return
> result.append("TextField");
> This should be DateTime or DateTimeField, right?

I Made this as DateTimeField.

>
https://codereview.chromium.org/616473002/diff/40001/ui/accessibility/ax_enum...
> File ui/accessibility/ax_enums.idl (right):
> 
>
https://codereview.chromium.org/616473002/diff/40001/ui/accessibility/ax_enum...
> ui/accessibility/ax_enums.idl:83: date,
> See this comment:
> 
> // For new entries to the following three enums, also add to
> // chrome/common/extensions/api/automation.idl.
> 
> Can you please double-check automation.idl is completely in sync? Add new
> unrelated enums if you see any other differences.

Synced automation.idl

[shreeramk, 2014-10-06 04:30:16]

On 2014/10/06 03:55:38, shreeram.k wrote:
> On 2014/10/01 19:42:06, dmazzoni wrote:
> > lgtm with two fixes
> > 
> >
>
https://codereview.chromium.org/616473002/diff/40001/content/shell/renderer/t...
> > File content/shell/renderer/test_runner/web_ax_object_proxy.cc (right):
> > 
> >
>
https://codereview.chromium.org/616473002/diff/40001/content/shell/renderer/t...
> > content/shell/renderer/test_runner/web_ax_object_proxy.cc:64: return
> > result.append("TextField");
> > This should be DateTime or DateTimeField, right?
> 
> I Made this as DateTimeField.
> 
> >
>
https://codereview.chromium.org/616473002/diff/40001/ui/accessibility/ax_enum...
> > File ui/accessibility/ax_enums.idl (right):
> > 
> >
>
https://codereview.chromium.org/616473002/diff/40001/ui/accessibility/ax_enum...
> > ui/accessibility/ax_enums.idl:83: date,
> > See this comment:
> > 
> > // For new entries to the following three enums, also add to
> > // chrome/common/extensions/api/automation.idl.
> > 
> > Can you please double-check automation.idl is completely in sync? Add new
> > unrelated enums if you see any other differences.
> 
> Synced automation.idl

automation.idl was synced by je_julie.

I ll add the input types related to date that je_julie skipped in her CL.

I was OOO from the last 3-4 days and changes have been done related to input
type dates. I am waiting for the trybot results.

[shreeramk, 2014-10-06 07:18:15]

PTAL!

Thanks

[dmazzoni, 2014-10-06 15:36:45]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-10-06 15:36:45]

lgtm

[commit-bot: I haz the power, 2014-10-06 15:38:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/616473002/120001

[commit-bot: I haz the power, 2014-10-06 17:25:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-06 17:25:05]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[shreeramk, 2014-10-07 06:56:14]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-07 06:57:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/616473002/140001

[commit-bot: I haz the power, 2014-10-07 08:40:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-07 08:40:12]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[shreeramk, 2014-10-07 08:41:49]

On 2014/10/07 08:40:12, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win8_chromium_rel on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

@Dominic: AccessibilityInputMonth is passing on win_chromium_rel but failing on
win8_chromium_rel.

[dmazzoni, 2014-10-07 15:56:34]

On 2014/10/07 08:41:49, shreeram.k wrote:
> On 2014/10/07 08:40:12, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   win8_chromium_rel on tryserver.chromium.win
> >
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
> 
> @Dominic: AccessibilityInputMonth is passing on win_chromium_rel but failing
on
> win8_chromium_rel.

Perhaps the input type is actually formatted differently on Win 8?

Please feel free to skip the test on Win 8 by adding #ifdefs around the TEST_F
in dump_accessibility_tree_browsertest.cc.

Alternatively, we could try to use @NO_DUMP or come up with something new like
that to hide everything other than the field itself, and not what's inside.

[shreeramk, 2014-10-08 12:09:13]

On 2014/10/07 15:56:34, dmazzoni wrote:
> On 2014/10/07 08:41:49, shreeram.k wrote:
> > On 2014/10/07 08:40:12, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders:
> > >   win8_chromium_rel on tryserver.chromium.win
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
> > 
> > @Dominic: AccessibilityInputMonth is passing on win_chromium_rel but failing
> on
> > win8_chromium_rel.
> 
> Perhaps the input type is actually formatted differently on Win 8?
> 
> Please feel free to skip the test on Win 8 by adding #ifdefs around the TEST_F
> in dump_accessibility_tree_browsertest.cc.
> 
> Alternatively, we could try to use @NO_DUMP or come up with something new like
> that to hide everything other than the field itself, and not what's inside.

Sorry. But I didn't get any specific flag related to OS Win 8. :(

[dmazzoni, 2014-10-08 19:31:10]

On 2014/10/08 12:09:13, shreeram.k wrote:
> On 2014/10/07 15:56:34, dmazzoni wrote:
> > On 2014/10/07 08:41:49, shreeram.k wrote:
> > > On 2014/10/07 08:40:12, I haz the power (commit-bot) wrote:
> > > > Try jobs failed on following builders:
> > > >   win8_chromium_rel on tryserver.chromium.win
> > > >
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
> > > 
> > > @Dominic: AccessibilityInputMonth is passing on win_chromium_rel but
failing
> > on
> > > win8_chromium_rel.
> > 
> > Perhaps the input type is actually formatted differently on Win 8?
> > 
> > Please feel free to skip the test on Win 8 by adding #ifdefs around the
TEST_F
> > in dump_accessibility_tree_browsertest.cc.
> > 
> > Alternatively, we could try to use @NO_DUMP or come up with something new
like
> > that to hide everything other than the field itself, and not what's inside.
> 
> Sorry. But I didn't get any specific flag related to OS Win 8. :(

Oh, of course - it'd have to be a runtime check, not a compile-time. You could
use this, if the platform is windows:

  base::win::GetVersion() >= base::win::VERSION_WIN8

Probably the best solution, though, would be to augment DumpAccessibilityTree to
make it possible to not dump the children of a given node. That way we could
dump the IA2_ROLE_DATE_EDITOR but not dump any of its children.

That should be a really simple change, similar to @NO_DUMP.

[shreeramk, 2014-10-15 10:31:28]

With the comments by tkent@chromium.org in this bug https://crbug.com/423675, it
doesn't seems to be a formatting bug by blink. I am disabling the test on
windows platform.

[shreeramk, 2014-10-15 10:50:59]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-15 10:52:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/616473002/160001

[commit-bot: I haz the power, 2014-10-15 12:01:05]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2014-10-15 12:01:54]

Patchset 9 (id:??) landed as
https://crrev.com/a89bdd193687e7cb9ad022bc01e97c93cbd018a6
Cr-Commit-Position: refs/heads/master@{#299677}