Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 615773002: Expose IA and IA2 role and state for HTML input type attributes related to date and time.(re-land) (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, jamesr, dglazkov+blink, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Expose IA and IA2 role and state for HTML input type attributes related to date and time.(re-land) For input type date, datetime and datetime-local, time, month, week - IA and IA2 role and states are not exposed properly. BUG=418486 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
shreeramk
Please review. (This one should be committed once this lands https://codereview.chromium.org/619473002/) Thanks!
6 years, 2 months ago (2014-09-30 06:16:47 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-09-30 06:34:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615773002/1
6 years, 2 months ago (2014-09-30 10:01:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182911
6 years, 2 months ago (2014-09-30 11:30:49 UTC) #6
shreeramk
On 2014/09/30 11:30:49, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 2 months ago (2014-09-30 14:52:08 UTC) #7
shreeramk
On 2014/09/30 14:52:08, shreeram.k wrote: > On 2014/09/30 11:30:49, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-09-30 15:53:25 UTC) #8
Zhenyao Mo
On 2014/09/30 15:53:25, shreeram.k wrote: > On 2014/09/30 14:52:08, shreeram.k wrote: > > On 2014/09/30 ...
6 years, 2 months ago (2014-09-30 16:58:04 UTC) #9
shreeramk
6 years, 2 months ago (2014-09-30 17:27:45 UTC) #10
Message was sent while issue was closed.
On 2014/09/30 16:58:04, Zhenyao Mo wrote:
> On 2014/09/30 15:53:25, shreeram.k wrote:
> > On 2014/09/30 14:52:08, shreeram.k wrote:
> > > On 2014/09/30 11:30:49, I haz the power (commit-bot) wrote:
> > > > Committed patchset #1 (id:1) as 182911
> > > 
> > > I came to know that Accessibility InputTime test case are failing on mac
and
> > > android. I ll skip it those test cases right now.
> > 
> > I have submitted this CL https://codereview.chromium.org/616003002/ to skip
> the
> > Accessibility test which are failing on mac and android.
> > 
> > This test cases are failing because chromium side dependancy for this bink
CL
> > has not been merged yet.
> > 
> > kindly don't revert this patch.
> 
> You did this in the wrong order.  You need to land the chromium side CL first
> (it's still in the CQ at the moment) before landing this.  Because of this
test
> failure, all Blink Rolls are blocked.

I am extremely sorry about this. I ll take care of this from next time onwards.

Powered by Google App Engine
This is Rietveld 408576698