Source/core/css/resolver/SharedStyleFinder.cpp - Issue 616443002: Implement :valid and :invalid pseudoclass for <form>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/SharedStyleFinder.cpp

Issue 616443002: Implement :valid and :invalid pseudoclass for <form> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add layout tests, apply feedback from Keishi, add support for removing/inserting elements into the … Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/form-pseudo-valid-style.html ('K') | « Source/core/css/SelectorChecker.cpp ('k') | Source/core/dom/Element.h » ('j') | Source/core/html/HTMLFormControlElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/SharedStyleFinder.cpp

diff --git a/Source/core/css/resolver/SharedStyleFinder.cpp b/Source/core/css/resolver/SharedStyleFinder.cpp

index ce16c0df1f0d4b7ef17a08556a3e785caf1906c7..c1130eab7f6c39556b50302751b124eccbd4d27f 100644

--- a/Source/core/css/resolver/SharedStyleFinder.cpp

+++ b/Source/core/css/resolver/SharedStyleFinder.cpp

@@ -84,7 +84,7 @@ bool SharedStyleFinder::canShareStyleWithControl(Element& candidate) const

if (willValidate != element().willValidate())

return false;

- if (willValidate && (candidate.isValidFormControlElement() != element().isValidFormControlElement()))

+ if (willValidate && (candidate.isValidElement() != element().isValidElement()))

return false;

if (candidate.isInRange() != element().isInRange())

@@ -242,6 +242,9 @@ bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const

|| toHTMLOptionElement(candidate).spatialNavigationFocused() != toHTMLOptionElement(element()).spatialNavigationFocused()))

return false;

+ if (candidate.isValidElement() != element().isValidElement())

keishi 2014/10/03 03:44:13 I think we should check document().containsValidit

Bartek Nowierski 2014/10/03 06:01:33 Done. And I moved this check to the bottom

+ return false;

// FIXME: This line is surprisingly hot, we may wish to inline hasDirectionAuto into StyleResolver.

if (candidate.isHTMLElement() && toHTMLElement(candidate).hasDirectionAuto())

return false;

« LayoutTests/fast/forms/form-pseudo-valid-style.html ('K') | « Source/core/css/SelectorChecker.cpp ('k') | Source/core/dom/Element.h » ('j') | Source/core/html/HTMLFormControlElement.cpp » ('J')