Source/core/css/SelectorChecker.cpp - Issue 616443002: Implement :valid and :invalid pseudoclass for <form>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/SelectorChecker.cpp

Issue 616443002: Implement :valid and :invalid pseudoclass for <form> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add layout tests, apply feedback from Keishi, add support for removing/inserting elements into the … Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/form-pseudo-valid-style.html ('K') | « Source/core/core.gypi ('k') | Source/core/css/resolver/SharedStyleFinder.cpp » ('j') | Source/core/css/resolver/SharedStyleFinder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/SelectorChecker.cpp

diff --git a/Source/core/css/SelectorChecker.cpp b/Source/core/css/SelectorChecker.cpp

index 954192c9b742debb79e72c6062c61ea3efa741a9..06b1ca0d4fe78f24c868871070f45650f5579ae4 100644

--- a/Source/core/css/SelectorChecker.cpp

+++ b/Source/core/css/SelectorChecker.cpp

@@ -807,10 +807,10 @@ bool SelectorChecker::checkOne(const SelectorCheckingContext& context, const Sib

return element.isRequiredFormControl();

case CSSSelector::PseudoValid:

element.document().setContainsValidityStyleRules();

- return element.willValidate() && element.isValidFormControlElement();

+ return element.willValidate() && element.isValidElement();

case CSSSelector::PseudoInvalid:

element.document().setContainsValidityStyleRules();

- return element.willValidate() && !element.isValidFormControlElement();

+ return element.willValidate() && !element.isValidElement();

case CSSSelector::PseudoChecked:

{

if (isHTMLInputElement(element)) {