Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 61643025: Allow Web Animations CSS flag to be turned off as well as on (Closed)

Created:
7 years, 1 month ago by Steve Block
Modified:
7 years, 1 month ago
Reviewers:
dstockwell, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Allow Web Animations CSS flag to be turned off as well as on This is a first step towards switching to Web Animations as the default implementation of CSS animations and transitions. When that switch is made, a virtual test suite will be added to run the animations and transitions LayoutTests with the legacy animations engine. Those virtual suites will require this --disable-web-animations-css flag. Also pass an explicit value to WebRuntimeFeatures::enableWebAnimationsSVG(), to allow the default value to be removed from Blink. BUG=258896 R=dstockwell@chromium.org, jam@chromium.org, dstockwell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235301

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Steve Block
This depends on r161978 being rolled into Chromium - https://codereview.chromium.org/66023004
7 years, 1 month ago (2013-11-14 04:40:37 UTC) #1
Steve Block
Rolled in with r235108 - https://codereview.chromium.org/72443003
7 years, 1 month ago (2013-11-14 09:33:37 UTC) #2
dstockwell
lgtm
7 years, 1 month ago (2013-11-14 22:47:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/61643025/1
7 years, 1 month ago (2013-11-14 23:41:10 UTC) #4
jam
lgtm with nit https://codereview.chromium.org/61643025/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/61643025/diff/1/content/public/common/content_switches.h#newcode175 content/public/common/content_switches.h:175: extern const char kDisableWebAnimationsCSS[]; please sort, ...
7 years, 1 month ago (2013-11-15 01:18:05 UTC) #5
Steve Block
https://codereview.chromium.org/61643025/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/61643025/diff/1/content/public/common/content_switches.h#newcode175 content/public/common/content_switches.h:175: extern const char kDisableWebAnimationsCSS[]; On 2013/11/15 01:18:06, jam wrote: ...
7 years, 1 month ago (2013-11-15 01:25:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/61643025/1
7 years, 1 month ago (2013-11-15 01:29:38 UTC) #7
commit-bot: I haz the power
Failed to trigger a try job on mac_rel HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-15 01:30:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/61643025/160001
7 years, 1 month ago (2013-11-15 03:55:35 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=190534
7 years, 1 month ago (2013-11-15 07:14:11 UTC) #10
Steve Block
Bot failures seem to be unrelated flakiness and this is low-risk, so landing manually.
7 years, 1 month ago (2013-11-15 07:19:43 UTC) #11
Steve Block
7 years, 1 month ago (2013-11-15 07:23:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r235301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698