Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 66023004: Allow Web Animations flags to be turned off as well as on (Closed)

Created:
7 years, 1 month ago by Steve Block
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Allow Web Animations flags to be turned off as well as on This is a first step towards switching to Web Animations as the default implementation of CSS animations and transitions. When that switch is made, a virtual test suite will be added to run the animations and transitions LayoutTests with the legacy animations engine. Those virtual suites will require a --disable-web-animations-css flag in Chromium, for which this change is a prerequisite. BUG=258896 R=abarth@chromium.org, dstockwell@chromium.org, dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Steve Block
7 years, 1 month ago (2013-11-11 11:35:25 UTC) #1
dstockwell
lgtm
7 years, 1 month ago (2013-11-11 12:01:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/66023004/1
7 years, 1 month ago (2013-11-11 12:58:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=10982
7 years, 1 month ago (2013-11-11 13:12:06 UTC) #4
abarth-chromium
lgtm
7 years, 1 month ago (2013-11-11 21:45:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/66023004/1
7 years, 1 month ago (2013-11-11 21:45:12 UTC) #6
Steve Block
This has been waiting for the linux_blink bot for over 48 hours now, and is ...
7 years, 1 month ago (2013-11-14 04:29:01 UTC) #7
Steve Block
7 years, 1 month ago (2013-11-14 04:29:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r161978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698