Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 61643010: Messaging for channels in the editor (dartbug.com/6980). (Closed)

Created:
7 years, 1 month ago by pquitslund
Modified:
7 years, 1 month ago
Reviewers:
ricow1, sethladd, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Messaging for channels in the editor (dartbug.com/6980). NOTE: the duplicated method getChannelLabel() will get cleaned up later. (Putting it in the right place now would make this CL harder to cherry-pick.) R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=30083

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/dialogs/AboutDartDialog.java View 1 2 chunks +19 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/update/UpdatePreferencePage.java View 1 2 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pquitslund
7 years, 1 month ago (2013-11-07 22:37:12 UTC) #1
danrubel
lgtm
7 years, 1 month ago (2013-11-07 23:12:54 UTC) #2
danrubel
https://codereview.chromium.org/61643010/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/dialogs/AboutDartDialog.java File editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/dialogs/AboutDartDialog.java (right): https://codereview.chromium.org/61643010/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/dialogs/AboutDartDialog.java#newcode62 editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/dialogs/AboutDartDialog.java:62: String updateUrl = UpdateCore.getUpdateUrl(); Can getUpdateUrl() ever return null?
7 years, 1 month ago (2013-11-07 23:20:19 UTC) #3
pquitslund
On 2013/11/07 23:20:19, danrubel wrote: > https://codereview.chromium.org/61643010/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/dialogs/AboutDartDialog.java > File > editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/dialogs/AboutDartDialog.java > (right): > > ...
7 years, 1 month ago (2013-11-07 23:22:26 UTC) #4
pquitslund
7 years, 1 month ago (2013-11-07 23:26:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r30083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698