Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 616263002: Log "title" in PlatformSetTitle(). (Closed)

Created:
6 years, 2 months ago by xhwang
Modified:
6 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Log "title" in PlatformSetTitle(). The "title" provides useful information in debugging. R=tedchoc@chromium.org Committed: https://crrev.com/68722de845c749dfc8dbac5f629b6cb40ea5a11a Cr-Commit-Position: refs/heads/master@{#297757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/browser/shell_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
xhwang
PTAL
6 years, 2 months ago (2014-10-01 05:28:25 UTC) #1
Ted C
lgtm
6 years, 2 months ago (2014-10-01 23:03:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616263002/1
6 years, 2 months ago (2014-10-02 00:15:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as b5fc42f925d577b8bc461485da77cde499212acd
6 years, 2 months ago (2014-10-02 01:15:16 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 01:17:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68722de845c749dfc8dbac5f629b6cb40ea5a11a
Cr-Commit-Position: refs/heads/master@{#297757}

Powered by Google App Engine
This is Rietveld 408576698